- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Thu, 14 Feb 2013 20:02:56 -0500
- To: "taka" <takaoshiyama@gmail.com>
- Cc: public-css-testsuite@w3.org
Le Jeu 14 février 2013 10:50, taka a écrit : > Hi > I appreciate your kind review for the subject test cases I have > submitted. > > test cases: text-orientation-010, 011, 012, 014.xht > reference files: text-orientation-010, 011, 012, 014-ref.xht > > http://test.csswg.org/shepherd/search/spec/css3-writing-modes/author/taka/status/submitted/ > > regards, http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-writing-modes/text-combine-horizontal-010.xht line 5: <title>CSS3 Writing Modes Test: text-combine-horizontal</title> I suggest <title>CSS Writing Modes Test: text-combine-horizontal - none</title> Nota bene: it should be CSS and not CSS3; we will want to reuse this test if/when there will be a CSS4 writing mode specification. One good method of writing title text in a consistent and predictable manner is: <title>CSS [Name_of_module] Test: [property_name] - [property_value] [optional: some_additional_parameters]</title> ------------- line 11: <meta name="flags" content="" /> Since your tests are requiring special, specific fonts, do not forget to add the font flag. ------------- line 12: <meta name="assert" content="This property allows the combination of multiple characters into the space of a single character ." /> The assert text describes the goal of the test, what it is testing. One good method of writing the text assert in a consistent and predictable manner is: <meta name="assert" content="This test checks, verifies that [property_name]: [property_value] with [some_additional_parameters] does [expected_results]." /> So, here, I would suggest: <meta name="assert" content="This test checks, verifies that 'text-combine-horizontal: none' does not combine multiple characters into the space of a single character." /> -------------- line 39: text-orientaion: mixed; should be text-orientation: mixed; ------------- line 50: <span class="tcy">1</span>月<span class="tcy">2</span>日の次の日は、<br /><span class="tcy">1</span>月<span class="tcy">3</span> Maybe I'm wrong here but... why is there no span with more than 1 character.. Shouldn't that be necessary in the test? Shouldn't that be what would be need to be tested? -------------- line 50: class attribute versus id attribute Class attribute is best used for logical grouping of many elements; semantically speaking, this was the genuine design intent for HTML. id attribute is best used for one single element in a document. So, a bit better is <div id="test"> ... </div> <div id="control"> ... </div> Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 15 February 2013 01:03:34 UTC