Re: [css3-multicol] Review of multicol-collapsing-001

Le Lun 5 août 2013 13:38, Håkon Wium Lie a écrit :
> Hello Gerard,
>
>  > Hello,
>  >
>  > http://test.csswg.org/source/contributors/opera/submitted/multicol/multicol-collapsing-001.xht
>  >
>  > In the test, column-gap is not declared and the spec grants UAs
> latitude
>  > on how wide the column-gap can be. Now, after checking the test and
> the
>  > reftest, it's clear that the column-gap should be set to 1em and
> should
>  > not be 0em: 8em (width) - 2em (column-gaps) is dividable by 3
>  > (column-count). The yellow background color shines through the 2
>  > column-gaps.
>  >
>  > Proposed replacement:
>  >
>  > http://www.gtalbot.org/BrowserBugsSection/CSS3Multi-Columns/Opera/multicol-collapsing-001-GT.xht
>  >
>  > ----------
>  >
>  > http://test.csswg.org/source/contributors/opera/submitted/multicol/multicol-collapsing-ref.xht
>  >
>  > The reftest is not best, not reliable (although it looks correct to
> me).
>  > I can see different renderings among browsers. The reftest should be
>  > using another feature (not a multi-column) to render the reference
> file.
>  >
>  > Proposed replacement:
>  >
>  > http://www.gtalbot.org/BrowserBugsSection/CSS3Multi-Columns/Opera/multicol-collapsing-001-GT-ref.xht
>  > (filename has "-001" appended)
>
> Looks good. Submitted.
>

Håkon,

You need to create a support folder inside

/contributors/opera/submitted/multicol

and then "hg-copy" into it swatch-yellow.png, swatch-blue.png,
swatch-green.png and black20x20.png . Mercurial has know that those are
copied images.

Also, now that multicol-collapsing-001-ref.xht has been created, you
should remove the previous:

multicol-collapsing-ref.xht     28-Apr-2013 13:35  843

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html

Received on Monday, 5 August 2013 18:17:44 UTC