- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Fri, 26 Oct 2012 16:55:32 -0400
- To: "Public CSS testsuite mailing list" <public-css-testsuite@w3.org>
Hello, [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/inlines-014.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/inlines-014.htm This test rendered layout is not predictable without knowing the used line-height value. 'line-height: normal' can be rendered as 1.0 to 1.2 and varies depending on local font used. Even when controling the font used (DejaVu Serif font), the line-height varies: Firefox 16.0.1 : 77px Opera 12.02 : 76px Chrome 22 and Konqueror 4.9.2 : 75px Furthermore, the test was most likely designed to take into consideration this. I propose line 12: td { padding: 0; border: 0; font-size: 64px; } to be replaced with line 12: td { padding: 0; border: 0; font-size: 2em; line-height: 2; } which will bring more precision to the test and also less leniency in verifying the implementation. At least with such code modifications, I have a much better chance to create a reliable, trustworthy reftest. I have a reftest ready on this. --------------------- [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/inlines-015.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/inlines-015.htm Same proposal: line 12: td { padding: 0; border: 0; font-size: 64px; } to be replaced with line 12: td { padding: 0; border: 0; font-size: 2em; line-height: 2; } which will bring more precision to the test and also less leniency in verifying the implementation. At least with such code modifications, I have a much better chance to create a reliable, trustworthy reftest. I have a reftest ready with such code modification. An even better code modification would be to use support/1x1-green.png instead of support/1x1-white.png in which case the exact, unknown, impredictable vertical position of the image ("sitting" on the baseline) would not be an issue in a reftest as everything inside the 64px by 128px rectangle would be green. --------------------- [RC6] http://test.csswg.org/suites/css2.1/20110323/html4/inlines-020.htm [nightly-unstable] http://test.csswg.org/suites/css2.1/nightly-unstable/html4/inlines-020.htm I have slightly modified this test. line 12: p, body, html { margin: 0; padding: 0; color: green; font: 20px/1 serif; } 'color: green' was unneeded line 13: div { display: inline; border-left: 3px solid lime; } The border-left is rather narrow, therefore a bit difficult to quickly and easily notice when taking a lot of tests; also lime is not green. line 20: <p class="pass">This line should be green (with a green vertical bar on the previous line).</p> The pass/fail conditions sentence has been modified slightly. Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 26 October 2012 20:56:03 UTC