- From: taka oshiyama <oshiyama@est.co.jp>
- Date: Tue, 08 Feb 2011 14:02:28 +0900
- To: public-css-testsuite@w3.org, Etemad Elika <fantasai@inkedblade.net>
- Cc: BizPal:梅原 智 <Umehara@est.bizpal.jp>, public-css-testsuite@w3.org, "epub.workers.ml@est.bizpal.jp" <epub.workers.ml@est.bizpal.jp>
- Message-ID: <4D50CE64.2080106@est.co.jp>
Hello fantasai, I've updated the file 'text-transform-006.xht' according to your comments and uploaded here http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/text-transform-006.xht for your kind review. Please find my answers in RED below. I understand each request/review transaction should address a single test case. (never multiple to avoid conflicts, keep clarity) Therefore, I isolated the file 'writing-mode-003.xht' for CSS Test: writing-mode - vertical-rl, and send separately for your review. Regards, Hello Taka, Here are my initial general comments: 1. Most of us don't understand Japanese, so please include both English and Japanese versions of the test instructions in the test. (You can use only English, but only Japanese makes it near-impossible for most of us to review.) Yes, changed to English (no Japanese so far, please advise if any corrections and/or suggestions needed in the descriptions) 2. Use .xht file extension so that the file gets served as XHTML. (An HTML copy will appear on the website automatically.) Yes, changed to .xhl. 3. The tests should be reftests if possible. This means a. Creating another, simpler XHTML page that does not use the feature you are testing but looks exactly the same as the indended rendering. b. Creating a reftest.list file in the directory that matches up the test and its reference. Okay, I understood it. In case of this test, I do not use it as I can make it self-explanatory. Here are my initial comments on text-transform-006: 1. The test should be comprehensive, that is, it should test every single small kana character in Unicode. (There aren't many, so this is not unreasonable.) In addition, it should test a small sample of other characters to make sure they are not affected, e.g. large kana remain large, and alphabetic characters do not get uppercased or lowercased. Yes, I updated. 2. Since this is very easy and very possible, test should ask for a comparison of the test text to a reference text, such as in these tests: http://test.csswg.org/suites/css2.1/20110111/xhtml1/text-transform-bicameral-008.xht http://test.csswg.org/suites/css2.1/20110111/xhtml1/content-counters-009.xht (The reftest reference would then be an exact copy of the test, except with two control elements instead of one control and one test.) Yes, I realized it without reftest. 3. The text-transform does not actually require the use of a particular font. It only requires that the font used have a glyph for the characters being tested. (CSS's fallback algorithm should take care of that.) If a system completely lacks a Japanese font, then the IPA font can be used as a suggestion, but the test shouldn't be flagged as requiring a special font. Yes, I updated accordingly, namely, no flag of IPA, instead I inserted scripts in order to use IPA font only if the system lacks a Japanese font. -- 押山 隆 takashi oshiyama oshiyama@est.co.jp (or takaoshiyama@gmail.com) mobile: 080-4148-7654 イースト株式会社 〒151-0053 渋谷区代々木2-22-8 www.est.co.jp
Received on Tuesday, 8 February 2011 05:55:00 UTC