CSS 2.1 test suite feedback: general test issues

I've been through about 60% of the HTML4 tests in the 20100917 suite, and have some feedback.

This message is about general issues with the tests themselves.

Many tests use the terms "text" and "line" interchangeably. In other, "text" specifically refers to the text foreground (e.g. "this test should be green"), and "line" to the background ("this line should be green"). There should be consistency here. The tests that I've found so far that have this ambiguity are:
	c15-ids-001 et al.
	at-charset-071
	first-line-pseudo-017 et al.
	matching-brackets-003
	margin-collapse-139 et al.

Similarly, some tests use the term "box", some "square" and some "block". I'm assuming that a "box" and "block" may be rectangular, but that a "square" must have sides of the same length. This is generally clear.

There's also ambiguity about whether these terms refer to a solid, filled box, or a hollow, bordered box. I've found these tests with ambiguity in this area:
	numbers-units-002
	border-width-applies-to-001
	positive-integer-001
	cascade-008
	border-left-width-095
	border-applies-to*

The easiest tests to judge are those that use the "This test should be green" technique. The hardest are those that use the descriptive form, like "there should a blue box on the left, and an orange box on the right, and the text must flow above the blue box and under the orange box". We should take very opportunity to convert tests to the former style.

Ref tests are by far the easiest to judge (as long as I don't have to scroll to see the entire test).

Some tests use a different green color that others. It would be easier if they all used the "green" color.

Simon