Re: review of bzbarsky's self-describing tests

On 3/16/10 1:36 AM, fantasai wrote:
> I think anonymous-block-not-containing-block one is pending a spec issue?
>
> http://test.csswg.org/source/contributors/bzbarsky/submitted/css2.1/visudet/anonymous-block-not-containing-block-001.xhtml
>
> http://wiki.csswg.org/spec/css2.1#issue-137

Correct.

> AFAICT, none of the tests in
> http://test.csswg.org/source/contributors/bzbarsky/submitted/css2.1/visuren/
>
> are testing what they think they're testing. They all continue to
> pass even if I change 'inherit' to 'auto'.

They do?  In what UA?

Changing any subset of the "inherit"s to "auto" in 
dynamic-top-change-001.xht causes the test to fail in trunk Gecko and in 
Opera 10.5 on Mac for me.

Changing the "inherit" to "auto" in dynamic-top-change-002.xht and 
dynamic-top-change-004.xht causes the tests to fail in trunk Gecko and 
in Opera 10.5 on Mac.

Changing the "inherit" to "auto" in dynamic-top-change-003.xht and 
dynamic-top-change-005.xht causes the tests to fail in trunk Gecko on 
Mac (they fail in Opera 10.5 with both settings; 003.xht due to the 
exact thing the tests are testing for, and 005.xht due to what looks 
like an unrelated Opera bug).

Webkit fails all of these with exactly the issue these tests are testing 
for, which is that "inherit" continues to inherit the "auto" value 
instead of inheriting the new value (or rather that the layout is not 
updated to take into account the non-auto value).

Can you please double-check and let me know how you reached your 
conclusions above?

> Also, they had the wrong file extensions (.xhtml instead of .xht).
> I fixed that so that they'll build, so you might want to svn update.

Thanks.

-Boris

Received on Sunday, 21 March 2010 14:32:54 UTC