Re: [Beta 3] comments on: height-inherit-001 , html4/relpos-calcs-001 (...) , replaced-intrinsic-004 and replaced-intrinsic-005

On 08/16/2010 08:35 AM, "Gérard Talbot" wrote:
> Hello all,
>
> 1-
> http://test.csswg.org/suites/css2.1/20100815/html4/height-inherit-001.htm
>
> I suggest to replace
>
>    <title>CSS Test: Inheriting Explicit Widths</title>
>    <link rel="author" title="Elika J. Etemad"
> href="http://fantasai.inkedblade.net/contact">
>    <link rel="help"
> href="http://www.w3.org/TR/CSS21/generate.html#list-style">
>    <meta name="flags" content="">
>    <meta name="assert" content="The computed width is inherited, even if
> the         'width' property does not apply.">
>
>
> with
>
>    <title>CSS Test: Inheriting Explicit Heights</title>
>    <link rel="author" title="Elika J. Etemad"
> href="http://fantasai.inkedblade.net/contact">
>    <link rel="help"
> href="http://www.w3.org/TR/CSS21/cascade.html#value-def-inherit">
>    <meta name="flags" content="">
>    <meta name="assert" content="The computed height is inherited, even if
> the 'height' property does not apply.">

Done.

> 2-
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-001.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-002.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-003.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-004.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-005.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-006.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/relpos-calcs-007.htm
>
> are all using a wrong doctype decl.

Fixed. I also ran a search&replace on Microsoft's testcases, where the
copy/paste error originally came from.

> 3-
> http://test.csswg.org/suites/css2.1/20100815/html4/replaced-intrinsic-004.htm
> http://test.csswg.org/suites/css2.1/20100815/html4/replaced-intrinsic-005.htm
>
>    <link rel="help" href="http://www.w3.org/TR/CSS21/syndata.html#at-rules">
>    (...)
>    <meta name="assert" content="@import is respected after invalid
> (ignored) rule set">
>
> do not seem to be about the goal of the testcases.
>
>    <link rel="help" href="http://www.w3.org/TR/CSS21/syndata.html#at-rules">
> should probably be replaced with
>    <link rel="help"
> href="http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height">
>
> Also
> <div class="container">  in replaced-intrinsic-004.htm :
> class container is not defined anywhere in the testcase.

Fixed.

Thanks for your review, Gérard,

~Elika

Received on Monday, 16 August 2010 23:30:41 UTC