W3C home > Mailing lists > Public > public-css-archive@w3.org > December 2020

Re: [csswg-drafts] [css-shapes-2] WIP: Add a draw() shape syntax, which accepts shape-segments equivalent to (#5711)

From: Mike Bremford via GitHub <sysbot+gh@w3.org>
Date: Wed, 02 Dec 2020 08:57:23 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-737089569-1606899442-sysbot+gh@w3.org>
Won't make the call to discuss, but this LGTM too. I think a straight drop-in replacement for the existing SVG syntax is a good idea. For that reason I also agree with keeping logical coordinates well away is a good idea, at least or now. I'm also not sure about "corner" - given you can replace `corner top right` with `move to 100% 0`, I don't think it adds anything. Maybe it was more useful when logical coordinates were an option; I'd consider dropping it until they're readded.

Otherwise, great! It's definitely better than string concatenation :-)

(oh, a quick addendum re. one of your earlier comments - arcs are not directly replaceable with beziers, as they are treated differently when used with SVG markers: a 270° arc with end markers has just the two, but drawing the same curve with beziers would result in more. So the concept needs to remain in the grammar. Yes the syntax is awkward, but it's well established, and using `small|large` and `cw|ccw` will certainly help)

-- 
GitHub Notification of comment by faceless2
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/5711#issuecomment-737089569 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 2 December 2020 08:57:25 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:42:23 UTC