W3C home > Mailing lists > Public > public-css-archive@w3.org > February 2018

Re: [csswg-drafts] [css-sizing-3] Spec disagrees with reality on how min-content / max-content contribution is computed for elements w/ intrinsic aspect ratio & percent size in opposite dimension

From: Daniel Holbert via GitHub <sysbot+gh@w3.org>
Date: Thu, 01 Feb 2018 16:42:06 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-362325390-1517503325-sysbot+gh@w3.org>
I think the relevant change is https://github.com/w3c/csswg-drafts/commit/7272dc55dee4ad563237fe1c750fe90f887c08d6#diff-a4403a9073e38ae7247def24db7b2eed , right?

(There's a link above saying "fantasai added a commit that referenced this issue" but that links to a [different seemingly-unrelated change](https://github.com/w3c/csswg-drafts/commit/86526ea1208ddeaac52d43087a717c9992cb4517).)

Assuming I'm understanding correctly about which commit I should be looking at, several nits:
(1) "this behaves as zero" - IMO we should avoid "behaves" since it's too vague. I think you're talking about the used value being zero here, correct?

(2) "For backwards-compatibility, the resolved value of this keyword is zero for [...] block and inline boxes"  -- this isn't strictly what you want to say, because flex items are "block boxes" (if they're  `display:block`, and the resolved value of this keyword is *not* zero for them.

(3) Is the word "zero" OK to use here, or should we use `0`? (Since `0` is an actual valid value for these properties, whereas "zero" is a bit vaguer (and does it mean 0% vs 0 vs 0px, etc.)

Suggestion: maybe you can address all three of these by replacing this with some language like:
> Unless other layout modules explicitly define another behavior,
> the used and resolved value of this keyword is `0`.

...and then other layout modes (grid/flex) should be sure to define that the `resolved value` is `auto`, and the `used value` is the special complex thing.  (RE "resolved value", maybe there's a way to describe all the CSS21 box-children in a sufficiently-precise way, but I'm not thinking of it right now.  Basically you want to say "everything which is not a grid item and not a flex item and not a future similar thing", which is a hard concept to encapsulate.)

-- 
GitHub Notification of comment by dholbert
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/2128#issuecomment-362325390 using your GitHub account
Received on Thursday, 1 February 2018 16:42:39 UTC

This archive was generated by hypermail 2.4.0 : Thursday, 24 March 2022 20:26:46 UTC