W3C home > Mailing lists > Public > public-css-archive@w3.org > November 2017

Re: [csswg-drafts] [css-align][css-grid] Baseline self-alignment may affect the intrinsic size contribution of the alignment subject.

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Wed, 22 Nov 2017 17:41:00 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-346423930-1511372459-sysbot+gh@w3.org>
The Working Group just discussed `Baseline self-alignment may affect the intrinsic size contribution of the alignment subject`, and agreed to the following resolutions:

* `RESOLVED: Accept the proposed change in the last comment of https://github.com/w3c/csswg-drafts/issues/1039`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: Baseline self-alignment may affect the intrinsic size contribution of the alignment subject<br>
&lt;gsnedders> dbaron: ah, ok, I didn't know what you were referring to earlier :)<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/1039<br>
&lt;fantasai> -> I hope if we discuss again, it's only because someone has found a better solution whose results don't look terrible<br>
&lt;dael> astearns: Who wants this?<br>
&lt;dael> TabAtkins: Bringing it up<br>
&lt;dael> TabAtkins: This is the more general case of which the last was a particular case. If a track depends on size of content and content is baseline aligned, then baseline alignment needs to depend on size of track.<br>
&lt;dael> TabAtkins: If you write algo niavely you end up circular.<br>
&lt;dael> TabAtkins: We've revised this a few times and hit on this approach. It's a small spec edit that does what we want as far as wel can tell. Details are toward the end and there are commits in the spec.<br>
&lt;fantasai> https://github.com/w3c/csswg-drafts/issues/1039#issuecomment-337327396 summarizes approach<br>
&lt;dael> TabAtkins: We collect all the baseline aligned items first, see height and how they will baseline aline. Then we add shims to them, basically margins, so if you niavely align it would be correct. Then we do baseline align.<br>
&lt;fantasai> changes at https://github.com/w3c/csswg-drafts/commit/36224722dc40432700709d1267b552b738ee3b49<br>
&lt;dael> TabAtkins: Javier says [quotes something positive]<br>
&lt;dael> astearns: At first blush this seems rasonable to me. I'm happy to make this change.<br>
&lt;gsnedders> dbaron, xidorn: looks like plenty of the tests in counters/ will run into https://github.com/w3c/web-platform-tests/issues/7757, though I guess if we just use list-style-position: inside that's good enough for all/most of them (and probably help encourage people to fix the Blink bug that'll cause those reftests to fail)<br>
&lt;dael> TabAtkins: Yeah, it wasn't something where coming from nothing you'd get it right. But I think we're good for now. We're open to changes to it. We just think we finally got it right.<br>
&lt;dael> astearns: Comments?<br>
&lt;Rossen_> "We think we finally got it right" TM :)<br>
&lt;dael> astearns: I'm assuming there's not any current interop?<br>
&lt;dael> TabAtkins: I believe so. It should be jsut doing what you expect it to do, but described currently instead of extra layout passes<br>
&lt;dael> astearns: Objections to this change?<br>
&lt;dael> RESOLVED: Accept the proposed change in the last comment of https://github.com/w3c/csswg-drafts/issues/1039<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/1039#issuecomment-346423930 using your GitHub account
Received on Wednesday, 22 November 2017 17:41:09 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 22 November 2017 17:41:10 UTC