W3C home > Mailing lists > Public > public-cognitive-a11y-tf@w3.org > February 2017

Re: process for second pull request

From: Andrew Kirkpatrick <akirkpat@adobe.com>
Date: Thu, 9 Feb 2017 22:56:22 +0000
To: lisa.seeman <lisa.seeman@zoho.com>, public-cognitive-a11y-tf <public-cognitive-a11y-tf@w3.org>
CC: Joshue O Connor <josh@interaccess.ie>, "W3c-Wai-Gl-Request@W3. Org" <w3c-wai-gl@w3.org>
Message-ID: <41B69EDB-94BA-43E2-A59A-13418C518E9D@adobe.com>
OK, so I found some time to run through this with an example.

I had an SC to propose, so I did the following:

  1.  I already had forked the W3C/WCAG21 repository (https://github.com/w3c/wcag21/) to my own repo (https://github.com/awkawk/wcag21/).
  2.  I made a new branch in my version of the repo (https://github.com/awkawk/wcag21/tree/MyWonderfulBranch)
  3.  I went to the guidelines page and added my new SC, and then after saving it I followed the prompt to create a pull request that shows up in the pull request list for the W3C/WCAG21 repo (https://github.com/w3c/wcag21/pull/117). This change is based on a single save operation, or commit. IT looks like the following in the GitHub screen:[cid:2AF0E0F9-9776-4B2F-89F5-E3D54158FD9A](https://github.com/w3c/wcag21/pull/117/commits/643ff7acb35e2e3223f22d51d0074447a31746ef)

Once the pull request is sumbitted, we will assume that we surveyed this SC and the group felt that it was almost perfect (or massively flawed), which means that I need to work on it further. So, this is what I do:


  1.  I got back to my branch (https://github.com/awkawk/wcag21/tree/MyWonderfulBranch) and make the edits that I need to make.
  2.  When I save my changes, this represents an additional commit and it automatically becomes part of the pull request.
  3.  In the pull request you can now see that there are two commits that make up the pull request. The second commit shows the changes that have been made since the first commit: https://github.com/w3c/wcag21/pull/117/commits/8d2ca858a97d3634c7dbd31c53adfbd55ad4790a

  4.  If you want to see the complete proposal for the pull request you just need to review the pull request pages:
     *   The pull request “conversation” page for comments.
     *   The list of commits that make up the pull request
     *   The code changes in the file or files (in this example there is only 1 file involved): https://github.com/w3c/wcag21/pull/117/files

        *   Some people like the “unified” view and others like the “split” view for file changes. There is a control that allows you to select which way to show the changes at the top of the files page.
           *   Unified: https://github.com/w3c/wcag21/pull/117/files?diff=unified

           *   Spilt: https://github.com/w3c/wcag21/pull/117/files?diff=split


If necessary, I can make further edits to the pull request, or the group may close the pull request without accepting it into the W3C/WCAG21 repo, or if the WG decides to it can accept it (merge the pull request) into the main repository.

I think that this process is similar to what you describe, except that there isn’t a second pull request, there are further edits to the existing pull request.

I hope this helps!


Thanks,
AWK

Andrew Kirkpatrick
Group Product Manager, Standards and Accessibility
Adobe

akirkpat@adobe.com
http://twitter.com/awkawk


From: Andrew Kirkpatrick <akirkpat@adobe.com<mailto:akirkpat@adobe.com>>
Date: Thursday, February 9, 2017 at 11:29
To: "lisa.seeman@zoho.com<mailto:lisa.seeman@zoho.com>" <lisa.seeman@zoho.com<mailto:lisa.seeman@zoho.com>>, "public-cognitive-a11y-tf@w3.org<mailto:public-cognitive-a11y-tf@w3.org>" <public-cognitive-a11y-tf@w3.org<mailto:public-cognitive-a11y-tf@w3.org>>
Cc: Joshue O Connor <josh@interaccess.ie<mailto:josh@interaccess.ie>>, WCAG <w3c-wai-gl@w3.org<mailto:w3c-wai-gl@w3.org>>
Subject: Re: process for second pull request
Resent-From: "public-cognitive-a11y-tf@w3.org<mailto:public-cognitive-a11y-tf@w3.org>" <public-cognitive-a11y-tf@w3.org<mailto:public-cognitive-a11y-tf@w3.org>>
Resent-Date: Thursday, February 9, 2017 at 11:29

Lisa,
I’m traveling today and it is late at night for Josh, so we may not be able to answer today, so do not assume that the process you describe below is correct if you don’t hear back today, it may be tomorrow before I can respond fully.

Thanks,
AWK

Andrew Kirkpatrick
Group Product Manager, Standards and Accessibility
Adobe

akirkpat@adobe.com<mailto:akirkpat@adobe.com>
http://twitter.com/awkawk


From: "lisa.seeman@zoho.com<mailto:lisa.seeman@zoho.com>" <lisa.seeman@zoho.com<mailto:lisa.seeman@zoho.com>>
Date: Thursday, February 9, 2017 at 10:43
To: "public-cognitive-a11y-tf@w3.org<mailto:public-cognitive-a11y-tf@w3.org>" <public-cognitive-a11y-tf@w3.org<mailto:public-cognitive-a11y-tf@w3.org>>
Cc: Andrew Kirkpatrick <akirkpat@adobe.com<mailto:akirkpat@adobe.com>>, Joshue O Connor <josh@interaccess.ie<mailto:josh@interaccess.ie>>, WCAG <w3c-wai-gl@w3.org<mailto:w3c-wai-gl@w3.org>>
Subject: process for second pull request

For doing a second pull request I suggested to coga the following process (because none of us knew what to do)

Please let us know today if anything here is incorrect.
(changes are in bold)



  1.   Develop a pull request on GitHub containing the new wording.
     *   Fork the WCAG21 repository to your own GitHub account
     *   Create a branch off of the Master branch (use a logical name for the branch, e.g. "Accessible authentication version 2 ”)
     *   Open the directory "guidelines" in your new branch
     *   open index. html , press the edit box
     *   navigate to the right guideline and  issert the following  with the SC text in the following mark up
<section class="sc">
<h4> </h4>
<p class="conformance-level">AA</p>
<p></p>
</section>
     *   Navigate to the glossary and add any new glossary  items (hopefully in the right place)
     *   Save and create the pull request for the Master branch.
  2.  When the Pull request is made:
     *   Provide the link to the first  pull request with some text along the lines of "this is a second pull request in response to the comments from the pull request at ...)
     *   Provide the link to the original issue in the pull request comments as well.
     *    Provide the link to the second pull request  from the first pull requet
ll the best

Lisa Seeman

LinkedIn<http://il.linkedin.com/in/lisaseeman/>, Twitter<https://twitter.com/SeemanLisa>


All the best

Lisa Seeman

LinkedIn<http://il.linkedin.com/in/lisaseeman/>, Twitter<https://twitter.com/SeemanLisa>


Screen Shot 2017-02-09 at 14.46.12.png
(image/png attachment: Screen_Shot_2017-02-09_at_14.46.12.png)

Received on Thursday, 9 February 2017 22:57:04 UTC

This archive was generated by hypermail 2.4.0 : Thursday, 24 March 2022 20:23:58 UTC