Re: VSS Presentation

Hi Rudi-san,

Thanks for the comments.

1. Using the vss2json.py tool
> <https://github.com/GENIVI/vehicle_signal_specification/blob/develop/tools/vspec2json.py> as
> a template
>

Although I made the tool just for ad hoc purpose,
 if you like to add it to the repository, it's happy to me.

Thanks for the instruction.
I modify the code and attached.

2. Splitting up the signal names into individual nodes
>
> Your tool is currently splitting up the signal names and places the
> individual nodes each into their own column in the csv file. I have been
> thinking about it. The biggest problem is that the tree is not limited in
> depth. There  can be any depth and you don't know how many columns are
> needed. The second problem is that you cannot easily look up a signal by
> its name because you have to search across columns. Maybe it's better to
> just put the signal name in its entirety into a single column? The csv file
> structure would then be:
>
> [Signal] ,[ID], [Type], [Unit], [Min], [Max], [Description]
>

Yes, I assumed maximum depth as 10 since it was enough for ad hoc purpose.
Your idea is fine and I modified the new version to followed this.

I'll make pull request, so please check it.

Since I don't use python much,
 excuse me for not smart code :-)

Best regards,
Shinjiro Urata


2016-09-13 1:48 GMT+09:00 Streif, Rudolf <rstreif@jaguarlandrover.com>:

> Urata-san,
>
> Thank you very much. This is looking really good. There are two more
> things I would like you to consider and I apologize for not bringing them
> up earlier:
>
>
> 1. Using the vss2json.py tool
> <https://github.com/GENIVI/vehicle_signal_specification/blob/develop/tools/vspec2json.py> as
> a template
>
> We already have three conversion tools that directly convert VSS into
> different output formats in the GENIVI Github repository
> <https://github.com/GENIVI/vehicle_signal_specification>. I would like to
> add your tool to the repo but it would be very beneficial if it followed
> the same template as the other tools. These tools directly read the VSS
> files. It's easy since the core of it is a converter that reads VSS YAML
> hierarchy into a JSON structure. All you have to do is
>
> import vspec
>
> tree = vspec.load(<vspec_file>, <include_dirs>)
>
> tree then contains the JSON tree structure alleviating you from reading
> the JSON file and omitting the vspec2json step. The vspec2json.py converter
> also contains the code to create the signal ID database.
>
>
> 2. Splitting up the signal names into individual nodes
>
> Your tool is currently splitting up the signal names and places the
> individual nodes each into their own column in the csv file. I have been
> thinking about it. The biggest problem is that the tree is not limited in
> depth. There  can be any depth and you don't know how many columns are
> needed. The second problem is that you cannot easily look up a signal by
> its name because you have to search across columns. Maybe it's better to
> just put the signal name in its entirety into a single column? The csv file
> structure would then be:
>
> [Signal] ,[ID], [Type], [Unit], [Min], [Max], [Description]
>
>
>
> Others, please weigh in here too.
>
> Thanks,
> Rudi
>
>
>
>
> On Sun, Sep 11, 2016 at 6:04 PM, Shinjiro Urata <shinjiro.urata@access-
> company.com> wrote:
>
>> Rudi-san,
>>
>> Thanks for the suggestion.
>> Hirabayashi-san gave me similar comment.
>>
>> Attahced is the format modified version (and omitted repetitive part such
>> as seat/door's Row2,3,..etc.).
>>
>> Thanks and regards,
>> Shinjiro Urata
>>
>>
>> 2016-09-08 3:22 GMT+09:00 Streif, Rudolf <rstreif@jaguarlandrover.com>:
>>
>>> Thank you, Urata-san.
>>>
>>> We would probably want to output the expanded fields of the leaf nodes
>>> in the form of:
>>>
>>> [ Attribute ], [ Cabin ], [ Seat ], [ DriverPostiion ], ...
>>> [ Attribute ], [ Cabin ], [ Seat ], [ Row1PosCount ], ...
>>> [ Attribute ], [ Cabin ], [ Seat ], [ Row2PosCount ], ...
>>>
>>> otherwise we will have this sparsely populated spreadsheet. Furthermore,
>>> with the current format the order of the lines in the file is essential
>>> otherwise the hierarchy is lost. Which means the file/spreadsheet cannot be
>>> sorted.
>>>
>>> BTW, yes, the vehicle speed was missing which was a blunt oversight.
>>> It's fixed now:
>>>
>>> Signal.Drivetrain.Transmission.Speed
>>> Signal.Cabin.Infotainment.Navigation.CurrentLocation.Speed
>>>
>>> Best regards,
>>> Rudi
>>>
>>> On Wed, Sep 7, 2016 at 1:51 AM, Shinjiro Urata <
>>> shinjiro.urata@access-company.com> wrote:
>>>
>>>> Hirabayashi-san, Rudi-san
>>>>
>>>> I tried conversion from vss_rel_1.json to csv with small script.
>>>> I don't know if this converted file fits to the needs.
>>>> Please have a look at attached file.
>>>>
>>>> >Hirabayashi-san
>>>> Since I omitted all other information except data point name,
>>>>  this may not very goot for cross check with older Vehicle Data Spec.
>>>> In that case, by modifiying the script, it is possible to
>>>>  add more information such as datatype, min/max, etc.
>>>>
>>>> Kind regards,
>>>> Shinjiro Urata
>>>>
>>>>
>>>>
>>>> 2016-09-07 10:30 GMT+09:00 <ta-hirabayashi@kddi-ri.jp>:
>>>>
>>>>> Rudi,
>>>>>
>>>>> Thanks, I got it in Paris f2f meeting.
>>>>>
>>>>> We need list of all vehicle signals/data as soon as possible to make
>>>>> sure
>>>>> overs and shorts comparing with the previous vehicle data specs.
>>>>>
>>>>> Vocabulary (data naming) list would be helpful in excel or csv format.
>>>>>
>>>>> Thank you in advance for your help.
>>>>>
>>>>> T.Hirabayashi
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>> > --
>>>>> > *Rudolf J Streif*
>>>>> > System Architect - Open Source Initiative
>>>>> > Open Source Technology Centre
>>>>> >
>>>>> > *M:* +1.619.631.5383
>>>>> > *Email:*  rstreif@jaguarlandrover.com
>>>>> >
>>>>> >
>>>>> >
>>>>> > UK: G/26/2 G02 Building 523, Engineering Centre, Gaydon, Warwick,
>>>>> CV35
>>>>> ORR
>>>>> > US: 1419 NW 14th Ave, Portland, OR 97209
>>>>> > jaguar.com | landrover.com
>>>>> > -------------------
>>>>> > Business Details:
>>>>> > Jaguar Land Rover Limited
>>>>> > Registered Office: Abbey Road, Whitley, Coventry CV3 4LF
>>>>> > Registered in England No: 1672070
>>>>> >
>>>>> > This e-mail and any attachments contain confidential information for
>>>>> a
>>>>> > specific individual and purpose.  The information is private and
>>>>> privileged
>>>>> > and intended solely for the use of the individual to whom it is
>>>>> addressed.
>>>>> > If you are not the intended recipient, please e-mail us immediately.
>>>>> We
>>>>> > apologise for any inconvenience caused but you are hereby notified
>>>>> that any
>>>>> > disclosure, copying or distribution or the taking of any action in
>>>>> reliance
>>>>> > on the information contained herein is strictly prohibited.
>>>>> >
>>>>> > This e-mail does not constitute an order for goods or services unless
>>>>> > accompanied by an official purchase order.
>>>>> >
>>>>> ～～～～～～～～～～～～～～～～～～
>>>>> ＫＤＤＩ総研
>>>>>
>>>>> 平林 立彦
>>>>> HIRABAYASHI Tatsuhiko
>>>>> Tel: 03-6678-1946(代表)
>>>>> Mobile: 080-5941-4506
>>>>> Fax: 03-6678-0339
>>>>> E-mail: ta-hirabayashi@kddi.com
>>>>> Address: 〒102‐8460
>>>>> 東京都千代田区飯田橋3-10-10
>>>>> ガーデンエアタワー33階
>>>>> ～～～～～～～～～～～～～～～～～～
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> .
>>>
>>>
>>>
>>>
>>> --
>>> *Rudolf J Streif*
>>> System Architect - Open Source Initiative
>>> Open Source Technology Centre
>>>
>>> *M:* +1.619.631.5383
>>> *Email:*  rstreif@jaguarlandrover.com
>>>
>>>
>>>
>>> UK: G/26/2 G02 Building 523, Engineering Centre, Gaydon, Warwick, CV35
>>> ORR
>>> US: 1419 NW 14th Ave, Portland, OR 97209
>>> jaguar.com | landrover.com
>>> -------------------
>>> Business Details:
>>> Jaguar Land Rover Limited
>>> Registered Office: Abbey Road, Whitley, Coventry CV3 4LF
>>> Registered in England No: 1672070
>>>
>>> This e-mail and any attachments contain confidential information for a
>>> specific individual and purpose.  The information is private and privileged
>>> and intended solely for the use of the individual to whom it is addressed.
>>> If you are not the intended recipient, please e-mail us immediately.  We
>>> apologise for any inconvenience caused but you are hereby notified that any
>>> disclosure, copying or distribution or the taking of any action in reliance
>>> on the information contained herein is strictly prohibited.
>>>
>>> This e-mail does not constitute an order for goods or services unless
>>> accompanied by an official purchase order.
>>>
>>>
>>
>> .
>
>
>
>
> --
> *Rudolf J Streif*
> System Architect - Open Source Initiative
> Open Source Technology Centre
>
> *M:* +1.619.631.5383
> *Email:*  rstreif@jaguarlandrover.com
>
>
>
> UK: G/26/2 G02 Building 523, Engineering Centre, Gaydon, Warwick, CV35 ORR
> US: 1419 NW 14th Ave, Portland, OR 97209
> jaguar.com | landrover.com
> -------------------
> Business Details:
> Jaguar Land Rover Limited
> Registered Office: Abbey Road, Whitley, Coventry CV3 4LF
> Registered in England No: 1672070
>
> This e-mail and any attachments contain confidential information for a
> specific individual and purpose.  The information is private and privileged
> and intended solely for the use of the individual to whom it is addressed.
> If you are not the intended recipient, please e-mail us immediately.  We
> apologise for any inconvenience caused but you are hereby notified that any
> disclosure, copying or distribution or the taking of any action in reliance
> on the information contained herein is strictly prohibited.
>
> This e-mail does not constitute an order for goods or services unless
> accompanied by an official purchase order.
>
>

-- 
.