Re: WaveShaperNode.curve

On Sun, May 12, 2013 at 2:20 PM, Ehsan Akhgari <ehsan.akhgari@gmail.com>wrote:

> The current WebKit implementation of this node is racy, since the
> processing code only protects against simultaneous setting of the curve
> property, not against modifying the contents of the ArrayBuffer.
>
> In the Gecko implementation, I'm just copying the contents of the array
> upon setting curve for now, but I think a better fix would be to neuter the
> contents of the array, and provide a copy of the original contents of the
> array if contents reads the curve property again.
>
> Does this make sense?
>

I much prefer an internal copy, and that can even be optimized as a fast
pointer swap.  I don't like the idea of harming the ArrayBuffer so that it
can't be used again.


>
> Thanks!
> --
> Ehsan
> <http://ehsanakhgari.org/>
>