W3C home > Mailing lists > Public > public-audio@w3.org > April to June 2013

Re: WaveShaperNode.curve

From: Chris Rogers <crogers@google.com>
Date: Sun, 12 May 2013 19:16:25 -0700
Message-ID: <CA+EzO0k4_BN6OsqsVMhKZTbt1GxTBmfgK6N_CPrJc8891OEAow@mail.gmail.com>
To: Ehsan Akhgari <ehsan.akhgari@gmail.com>
Cc: "public-audio@w3.org" <public-audio@w3.org>
On Sun, May 12, 2013 at 2:20 PM, Ehsan Akhgari <ehsan.akhgari@gmail.com>wrote:

> The current WebKit implementation of this node is racy, since the
> processing code only protects against simultaneous setting of the curve
> property, not against modifying the contents of the ArrayBuffer.
>
> In the Gecko implementation, I'm just copying the contents of the array
> upon setting curve for now, but I think a better fix would be to neuter the
> contents of the array, and provide a copy of the original contents of the
> array if contents reads the curve property again.
>
> Does this make sense?
>

I much prefer an internal copy, and that can even be optimized as a fast
pointer swap.  I don't like the idea of harming the ArrayBuffer so that it
can't be used again.


>
> Thanks!
> --
> Ehsan
> <http://ehsanakhgari.org/>
>
Received on Monday, 13 May 2013 02:16:55 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:03:18 UTC