- From: <bugzilla@jessica.w3.org>
- Date: Thu, 13 Dec 2012 15:31:59 +0000
- To: public-audio@w3.org
https://www.w3.org/Bugs/Public/show_bug.cgi?id=20364
Jussi Kalliokoski <jussi.kalliokoski@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jussi.kalliokoski@gmail.com
--- Comment #1 from Jussi Kalliokoski <jussi.kalliokoski@gmail.com> ---
(In reply to comment #0)
> From Marcos Caceres (marcos@marcosc.com)
>
> The following is not defined correctly:
>
> [NoInterfaceObject]
> interface NavigatorMIDIAccess {
> void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback,
> optional NavigatorMIDIAccessErrorCallback? errorCallback);
>
> };
>
>
> Should just be:
>
> partial interface Navigator {
> void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback,
> optional NavigatorMIDIAccessErrorCallback? errorCallback);
> };
>
Not fixed yet.
>
>
> Bikeshed: NavigatorMIDIAccessSuccessCallback is a little excessive :) Just
> called them "successcb" and "failcb". They are just functions without a
> "real" interface, so no need to go all camel case there :)
Fixed: https://dvcs.w3.org/hg/audio/rev/bf4f6fd3ecef
> Also, MIDIPort should not be a [NoInterfaceObject]. Either fold it into
> MIDIOutput or make it into a partial interface.
>
> Generally speaking, don't make things [NoInterfaceObject]. WebIDL says not
> to do that unless its for Legacy reasons:
>
> [[
> Warning
>
> The [NoInterfaceObject] (http://www.w3.org/TR/WebIDL/#NoInterfaceObject)
> extended attribute should not be used on interfaces that are not solely used
> as supplemental (http://www.w3.org/TR/WebIDL/#dfn-supplemental-interface)
> interfaces, unless there are clear Web compatibility reasons for doing so.
> Specification authors who wish to use this feature are strongly advised to
> discuss this on the public-script-coord@w3.org
> (mailto:public-script-coord@w3.org) mailing list before proceeding.
> ]]
>
> Also applied to MIDIEvent.
Fixed: https://dvcs.w3.org/hg/audio/rev/bf4f6fd3ecef
--
You are receiving this mail because:
You are the QA Contact for the bug.
Received on Thursday, 13 December 2012 15:32:01 UTC