Re: [widgets] Request for review for 14th of April

Hi David,
Thanks for the review. Fixed everything you pointed out... some
comments below.

>  Some comments:
>
>  In section "1.2 Definitions":
>
>  | A widget resource is digitally signed is it contains [...]
>
>  "is it" -> "if it".

Fixed.

>  "6. Configuration Document":
>
>  | Authoring requirement:It is recommended [...]
>
>  Missing space after the colon.

Fixed.

>  The first example uses a "title" element, which should be "name".

Fixed.

>  The second example does not declare the namespace, but "6.1 Namespace" says
> that this must be done.

Fixed (argh! namespaces!:))

>
>  "6.1 Namespace":
>
>  | [...]. If it is omited [...]
>
>  Missing a "t".

Fixed.

>
>  "6.2 Attribute Values and Types", "Boolen Attributes":
>
>  | [...]. A valid boolean value is must is a string [...]
>
>  Sounds strange ;-)

Changed to "A valid boolean value is a string that case insensitively
matches true or false".

>
>  For the element types, some say "Contexts in which this element must/may be
> declared" and some says "present" instead of "declared". The same word
> should be used for consistency. (The word used in the HTML 5 spec is "used"
> btw. That may be even better).

Ok, changed all "declared" and "present" to "used". All "undeclared"
have been changed to "missing".

>  The name element is the only one that has "Expected children: None.". It
> should be removed.

Done.

>
>  "7. Steps for Processing a Widget Resource":
>
>  | The steps listed as follows and are specified verify the
>  | zip archive its file entriesin detail in the following sub-
>  | sections.
>
>  "entriesin" -> "entries in". This sentence also sound extremely weird IMO.
> Is it missing some commas or something?

Woops! I have no idea what I was trying to say there:P I removed that
sentence.

>
>  "7.3 Defaults":
>
>  | Icons
>  |   empty list of URIs
>
>  "Empty list" alone sounds better IMO, because if it's empty, there
> certainly aren't any URIs.

Done.

>
>  "7.4 Parsing Rules":
>
>  | User agents may optimize any of the parsing [...]
>
>  This is pretty much a repetition of the first note under "7. Steps for
> Processing a Widget Resource".

Deleted the text from 7.4. Modified the note in section 7.0 to read:
"Note: the following steps are written with more concern for clarity
than over efficiency. As such, user agents may optimize any of the
steps (or may perform them in a different order) and parsing rules, so
long as the end result is indistinguishable from the result that would
be obtained by the following the specification."

>  "Step 6 - Process the configuration document", first example:
>
>  | [...] walking an through an element's children [...]
>
>  The first "an" should be removed.

Fixed.

>  Also, in the same example there should be a "name" element, not "title".

Fixed.

>
>  In the schema, "title = element name" should be "name = element name".

Fixed.

>
>  Nitpick: Some headers (e.g. "4. Zip Archive") are bolder than others
> (because of <dfn>'s I presume). Maybe this should be fixed for consistency.

Yeah, I need to go through and fix all those. I will leave them for
now and do a clean up of the markup for the next pub cycle...

Thanks again!!!

Kind regards,
Marcos

-- 
Marcos Caceres
http://datadriven.com.au

Received on Saturday, 5 April 2008 06:05:23 UTC