W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2009

RE: Comments on Microsoft Chapter 4 Tests

From: Grant, Melinda <melinda.grant@hp.com>
Date: Wed, 18 Mar 2009 19:00:48 +0000
To: Anne van Kesteren <annevk@opera.com>, "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
Message-ID: <763AE400FE923441B74861D534DF25495DED282807@GVW0433EXB.americas.hpqcorp.net>

Anne said:
> In general I would like all tests that use the
> 
>     <p>Test passes if the "Filler Text" below is green.</p>
>     <div>Filler Text</div>
> 
> to change into using the
> 
>     <p>This line should have a green color.</p> 

Assuming others agree that in general this is a good change (it seems so to me), I think the text needs to be more descriptive of the expected output, in this case,  
	<p>This text should be green.</p>

In many existing tests, it's not clear without examining the source whether the text should be green or whether it should have a green background, whether the background should extend across the page, etc.  I've had testers fail tests that use the "This line..." description because there is no line on the page...

We need to be more explicit, ala,

	<p>This sentence should have a green background which extends across the display area.</p>
	<p>This paragraph should be inside a green rectangle.</p>
	<p>This sentence has a solid green line beneath it which spans spaces between words.</p>

Etc.

My 2 bits,

Melinda

> -----Original Message-----
> From: public-css-testsuite-request@w3.org 
> [mailto:public-css-testsuite-request@w3.org] On Behalf Of 
> Anne van Kesteren
> Sent: Wednesday, March 18, 2009 6:21 AM
> To: public-css-testsuite@w3.org
> Subject: Comments on Microsoft Chapter 4 Tests
> 
> I was tasked with reviewing the Chapter_4 contributions and 
> have some general comments. Now I believe the idea was that I 
> would simply fix the tests and that the author of the test 
> would verify the change and it would be all set. However, 
> given the (unresolved) dispute over 
> attribute-value-selector-004.xht I'm not sure I want to do 
> work on changing tests as apparently there is disagreement 
> about whether certain rules test the same thing.
> 
> In general I would like all tests that use the
> 
>     <p>Test passes if the "Filler Text" below is green.</p>
>     <div>Filler Text</div>
> 
> to change into using the
> 
>     <p>This line should have a green color.</p>
> 
> pattern or equivalent. E.g.
> 
>     <div>This line should have a green color.</div>
> 
> would probably work better for some tests given the existing 
> shared @import style sheets.
> 
> I think this makes it easier to see whether a test passed or 
> failed. It is also the convention similar existing tests are 
> following.
> 
> Is changing tests along these lines fine?
> 
> 
> --
> Anne van Kesteren
> http://annevankesteren.nl/

> 
> 
Received on Wednesday, 18 March 2009 19:02:09 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:51:58 GMT