W3C home > Mailing lists > Public > public-css-testsuite@w3.org > July 2008

Re: CSS2.1 i18n and bidi tests for review

From: fantasai <fantasai.lists@inkedblade.net>
Date: Fri, 04 Jul 2008 15:14:51 -0700
Message-ID: <486EA0DB.7010207@inkedblade.net>
To: Eira Monstad <eiram@opera.com>
CC: public-css-testsuite@w3.org, 'Richard Ishida' <ishida@w3.org>

Eira Monstad wrote:
> 
> Cheers,
> 
> I've been working on some bidi related tests for the 2.1 testsuite, as 
> well as converting a few of Richard Ishida's tests for language 
> dependent styling to match the testsuite template. The tests are ready 
> for review at http://people.opera.com/eiram/test/css21/review/

http://people.opera.com/eiram/test/css21/review/attribute-selector-001.xht

   - I recommend using background-color rather than color, as
     it is much more obvious to the eye.
   - If possible, place all the green lines together and all
     the non-green lines separately. This makes the test easier
     to scan.
   - The 'lang' attribute itself is case-insensitive in HTML,
     but afaik its value is case-sensitive. So the ES test is
     wrong. What you can do is vary the case of the string
     'lang' itself in both the source and the CSS.
   - [xml:lang="foo"] is invalid CSS. The attribute name must
     be an identifier, so you'd have to escape the ':'. The
     xml:lang attribute is invalid in HTML, though, so I think
     we'll need to remove this test altogether.

http://people.opera.com/eiram/test/css21/review/attribute-selector-002.xht

   - I recommend using background-color rather than color, as
     it is much more obvious to the eye.
   - If possible, place all the green lines together and all
     the non-green lines separately. This makes the test easier
     to scan.
   - If the goal here is to test case-sensitivity, as the assertion
     indicates, you need to vary the case and make sure mismatches
     don't match.
   - The title should just say "attribute selector", not "lang
     attribute selector" since we're actually testing 'title' here.

http://people.opera.com/eiram/test/css21/review/attribute-selector-003.xht
http://people.opera.com/eiram/test/css21/review/attribute-selector-004.xht
   Comments as above.

Since your test files include multiple tests, you might want to
throw in some variation on quotation (",',none) and/or spacing
in the CSS, just to cover that aspect as well.

http://people.opera.com/eiram/test/css21/review/lang-pseudoclass-001.xht
http://people.opera.com/eiram/test/css21/review/lang-pseudoclass-002.xht
   Same comments about background-color etc.. but I think we need
   a spec clarification here before I can review the content of
   the test. I would expect :lang to be case-insensitive because
   the language codes are... But that's not specified in the spec,
   so.. I guess I'll have to file an issue.

~fantasai
Received on Friday, 4 July 2008 22:15:40 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:51:56 GMT