RE: Primer Review

My earlier comment that it should be {checkAvailability} was wrong.  It
should remain as {checkInDate}.  

 

I believe that only leaf nodes can be specified.  Section 4.2 IRI style
says it has to be a sequence.

 

As I read the spec, the example with location="{checkInDate}" should
become a URI option a).  Perhaps the example address attribute should be
updated to add the "checkAvailability" to be a more descriptive URI.

 

Cheers,

Dave

 

  _____  

From: Liu, Kevin [mailto:kevin.liu@sap.com] 
Sent: Wednesday, July 06, 2005 12:46 PM
To: David Orchard; www-ws-desc@w3.org
Subject: RE: Primer Review

 

Hi David,

 

While incorporating your suggestions below, I came across a few more
questions. Please see below.

Best Regards,
Kevin
  

 

	 

	
  _____  


	From: www-ws-desc-request@w3.org
[mailto:www-ws-desc-request@w3.org] On Behalf Of David Orchard
	Sent: Thursday, Jun 30, 2005 12:19 PM
	To: www-ws-desc@w3.org
	Subject: Primer Review

	I reviewed the primer for the HTTP binding and ext/versioning
examples.  I did find a few things that need or could use changing.

	 

	2.5.6

	As DavidB suggests, the example should be {checkAvailability}
	[Kevin] I don't quite understand your point here. Do you mean
change the value of whttp:location in example 2-12 to
"{CheckAvailability}"? That doesn't answer the question in the Ed note.

	 

	Let's have a closer look at the definition of
{CheckAvailability}

	 

	      <xs:element name="checkAvailability"
type="tCheckAvailability"/>    
	      <xs:complexType name="tCheckAvailability">     
	        <xs:sequence>      
	          <xs:element  name="checkInDate" type="xs:date"/>      
	          <xs:element  name="checkOutDate" type="xs:date"/>

	          <xs:element  name="roomType" type="xs:string"/>      
	        </xs:sequence>     
	      </xs:complexType>   

	 

	The question is what kind of elements can be assigned to the
whttp:location.  Should it only be "leaf" element such as "checkInDate"?
or can it be an element that is defined using a complex type, such as
CheckAvailability which contains three children elements. In the
following example, if we let whttp:location = "{CheckAvailability}, then
how the serialization works?   

	 

	If we let whttp:location= "{checkInDate}", should
"checkAvailability" be part of the URI? more specifically, should the
URI be a, b, or something else? 

	a.
http://greath.example.com/2004/5-5-5?checkOutDate=6-6-5&roomType=foo 

	b.
http://greath.example.com/2004/checkAvailability/5-5-5?checkOutDate=6-6-
5&roomType=foo
<http://greath.example.com/2004/checkAvailability/5-5-5?checkOutDate=6-6
-5&roomType=foo> . 

	 

	 

	 

	Upon further reflection, I'd suggest changing the section a bit
by having the first example use the safe attribute 

	 and then an example that shows methodDefault, rather than the
inverse as is done now.

	 

	I suggest that example 2-14 just shows setting the
defaultMethod.

	[Kevin]  you mean take whttp:methodDefault="GET" out from
example 2-12, and move it to example 2-14? 

	 

	
	 

	 5.2.5.1. Change "The reservation service can accept" to "The
reservation service is changed to a newer version that can accept"

	 

	5.2.5.3 s/Mandadtory/Mandatory/g

	 

	5.2.5.5 Formatting of example needs indenting, operation needs
closing >

	 

	5.2.5.7 Formatting of example needs indenting for wsoap:action

	 

	5.2.5.8.  The example should be

	 

	<xs:element name="ghns2:makeReservation"
type="ghns:tmakeReservation"/>

	 

	<interface . . .>

	   <operation name="makeReservation">

	       <input messageLabel="In" element="ghns2:makeReservation"
/>

	</interface>