- From: Jim Barnett <1jhbarnett@gmail.com>
- Date: Sat, 28 Jun 2014 08:32:05 -0400
- To: www-voice@w3.org
Thanks, I'll fix these in the next draft. - Jim On 6/27/2014 10:24 PM, Gavin Kistner wrote: > 1) The spec uses “documentOrder” in two places (selectEventlessTransitions and selectTransitions), where it presumably should use “entryOrder”. > > 2) The spec uses isScxmlState() in exitInterpreter() but isSCXMLElement() in enterStates(); the latter should probably be isScxmlState() for consistency with other is____State() functions. > > 3) Some of the functions use three spaces for indentation, some use four. Some are mixed (e.g. first line of exitStates versus other lines). It would be nice if this was consistent (but not necessary). > > 4) There are a few indentation issues that might cause confusion: > 4a) In exitStates() the line beginning with "historyValue[h.id]” does not match any other indentation levels. > 4b) In computeExitSet() the 3rd line is indented more than the 2nd, but I believe it should not be. > 4c) In getEffectiveTargetStates() the header is missing a space after ‘function’ > 4d) In getEffectiveTargetStates() the outer if/else is not aligned vertically. > 4e) The comment in removeConflictingTransitions() is indented in an odd manner. > > 5) There are two statements ending in semicolons. I believe that these should not be present. > > 6) In computeExitSet() the condition for the ‘if' statement is parenthesized. This is the only case where this is used. -- Jim Barnett Genesys
Received on Saturday, 28 June 2014 12:32:46 UTC