W3C home > Mailing lists > Public > www-svg@w3.org > December 2013

Re: Relaxing SVGList* item object equality in Blink/Chromium

From: Dirk Schulze <dschulze@adobe.com>
Date: Fri, 13 Dec 2013 06:53:59 +0000
To: Boris Zbarsky <bzbarsky@MIT.EDU>
CC: www-svg <www-svg@w3.org>, Rebecca Hauck <rhauck@adobe.com>
Message-ID: <5591DDEE-713A-4FC7-B900-812E8B1D2EDC@adobe.com>

On Dec 12, 2013, at 9:01 PM, Boris Zbarsky <bzbarsky@MIT.EDU> wrote:

> On 12/12/13 2:34 PM, Dirk Schulze wrote:
>> [1] https://github.com/w3c/csswg-test/tree/master/contributors/adobe/incoming/svg-transform/dom
> 
> Thanks.
> 
> Most of the animVal failures I see here are due to the tests expecting an exception with e.name == 'NO_MODIFICATION_ALLOWED_ERR'.
> 
> The exceptions Gecko throws in this case have e.name == NoModificationAllowedError and e.code == DOMException.NO_MODIFICATION_ALLOWED_ERR.
> 
> Chrome also has e.name == NoModificationAllowedError.
> 
> And the reason for that is that the DOM spec explicitly calls for that behavior.  If you look at http://dom.spec.whatwg.org/#error-names-0 the error name is "NoModificationAllowedError".
> 
> If I fix the test bug so the tests test for the right string, Gecko passes the most of the animval tests in question.  The remainder are ones like gradientTransformAnimValSetSkewY which actually seem to be testing that animated values _can_ be modified.  Which they can't, so those tests get exceptions when they try to do it.

Thanks a lot for the review Boris! We will investigate in the issues and submit the tests for a 2nd review.

Greetings,
Dirk


> 
> -Boris
Received on Friday, 13 December 2013 06:54:30 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 22:54:49 UTC