W3C home > Mailing lists > Public > www-svg@w3.org > December 2013

Re: Relaxing SVGList* item object equality in Blink/Chromium

From: Boris Zbarsky <bzbarsky@MIT.EDU>
Date: Thu, 12 Dec 2013 15:01:27 -0500
Message-ID: <52AA1617.4040700@mit.edu>
To: Dirk Schulze <dschulze@adobe.com>
CC: www-svg <www-svg@w3.org>
On 12/12/13 2:34 PM, Dirk Schulze wrote:
> [1] https://github.com/w3c/csswg-test/tree/master/contributors/adobe/incoming/svg-transform/dom

Thanks.

Most of the animVal failures I see here are due to the tests expecting 
an exception with e.name == 'NO_MODIFICATION_ALLOWED_ERR'.

The exceptions Gecko throws in this case have e.name == 
NoModificationAllowedError and e.code == 
DOMException.NO_MODIFICATION_ALLOWED_ERR.

Chrome also has e.name == NoModificationAllowedError.

And the reason for that is that the DOM spec explicitly calls for that 
behavior.  If you look at http://dom.spec.whatwg.org/#error-names-0 the 
error name is "NoModificationAllowedError".

If I fix the test bug so the tests test for the right string, Gecko 
passes the most of the animval tests in question.  The remainder are 
ones like gradientTransformAnimValSetSkewY which actually seem to be 
testing that animated values _can_ be modified.  Which they can't, so 
those tests get exceptions when they try to do it.

-Boris
Received on Thursday, 12 December 2013 20:01:57 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 22:54:49 UTC