W3C home > Mailing lists > Public > www-style@w3.org > April 2015

Re: [css-font-loading] maintaining invariants of a FontFaceSet’s set entries

From: Tab Atkins Jr. <jackalmage@gmail.com>
Date: Fri, 10 Apr 2015 11:42:31 -0700
Message-ID: <CAAWBYDAvpNuuxr2nKS_J_U5WWBEj1mh_g0COMDU7H3ikLf5B1g@mail.gmail.com>
To: "Tab Atkins Jr." <jackalmage@gmail.com>, www-style list <www-style@w3.org>
On Wed, Apr 8, 2015 at 9:45 PM, Cameron McCormack <cam@mcc.id.au> wrote:
> Tab Atkins Jr.:
>> > 3. Similarly, FontFaceSet.delete() used to throw when trying to remove a
>> > CSS-connected FontFace.  Whether an exception is thrown or the request
>> > is ignored, I don’t particularly mind.  Ignoring the request is probably
>> > implied by the requirement to keep all CSS-connected FontFaces in there
>> > by §4.2, but should be made explicit somewhere.  That would be
>> > consistent with having clear() not throw because it is attempting to
>> > remove the CSS-connected entries, too.
>>
>> Done, it's specced as a no-op.
>
> We need to specify the return value from delete.  Since
> Set.prototype.delete never fails to delete an item that is in the Set,
> we don’t have a precedent for whether it should return false or true.
> But I think false makes sense.

Good catch. Done.

~TJ
Received on Friday, 10 April 2015 18:43:18 UTC

This archive was generated by hypermail 2.3.1 : Monday, 2 May 2016 14:39:30 UTC