W3C home > Mailing lists > Public > www-style@w3.org > January 2014

Re: [css-flexbox] Typo in new "Resolving Flexible Lengths" text ('hypothetical main size' in step 5 substep 4)

From: Daniel Holbert <dholbert@mozilla.com>
Date: Thu, 30 Jan 2014 10:16:50 -0800
Message-ID: <52EA9712.2000406@mozilla.com>
To: www-style <www-style@w3.org>
CC: "Tab Atkins Jr." <jackalmage@gmail.com>
Thanks!

While you're at it, it's probably worth clarifying another thing about
that step.

It currently says:
  # 4. <b>Adjust main size.</b> Add each item's
  # desired free space to its flex base size.

That text is a bit vague about what happens with the result of the
addition. "Add...to its flex base size" even sounds a bit like it's
saying to *modify the flex base size* (i.e. flexBaseSize +=
desiredFreeSpace), which is definitely not what we want.

The step-title's mention of "main size" clears things up a bit, but it'd
be good to mention "main size" in the actual text of the step, too.

Maybe something like:
  # 4. <b>Adjust main size.</b> Set each item's main size
  # to the sum of its flex base and its desired free space.

(or maybe even "Set each item's _inner_ main size"?)

Thanks,
~Daniel

On 01/29/2014 07:18 PM, Tab Atkins Jr. wrote:
> On Wed, Jan 29, 2014 at 5:16 PM, Daniel Holbert <dholbert@mozilla.com> wrote:
>> Hi Tab,
>>
>> I've been reviewing the new "Resolving Flexible Lengths" text, here:
>> http://dev.w3.org/csswg/css-flexbox/#resolve-flexible-lengths
>> ...and I noticed what I think is a minor bug in the new algorithm.
>>
>> Specifically: In Step 5(loop) substep 4, for "Adjust main size", it
>> currently says:
>>  # Add each item's desired free space to its hypothetical main size.
>>
>> Instead of "hypothetical main size" there, I think it *wants* to say
>> "flex base size". (Note that the former takes min/max-clamping into
>> account; the latter does not.)
> 
> Yup, mistake on my part. Fixed!
> 
> ~TJ
> 
Received on Thursday, 30 January 2014 18:17:20 UTC

This archive was generated by hypermail 2.4.0 : Friday, 25 March 2022 10:08:39 UTC