Re: [css-color] hslToRgb corruption in css-color-4 version

• From: Tab Atkins Jr. <jackalmage@gmail.com>
• Date: Tue, 28 Jan 2014 07:38:50 -0800
• To: Peter Moulder <pjrm@mail.internode.on.net>
• Cc: www-style list <www-style@w3.org>
• Message-ID: <CAAWBYDDJr7ggbM_uyNeUDrDdC2J+1ZB0g60Br0C1b2+P+o6wDQ@mail.gmail.com>

On Tue, Jan 28, 2014 at 3:33 AM, Peter Moulder
<pjrm@mail.internode.on.net> wrote:
> Nearby typo: "as an a" -> "as a".  (css-color-4 version only.)
>
>
> A simple error crept into the hslToRgb function in the conversion to
> JavaScript: the initialization of t1 should be calculated from t2, not from t1.

Fixed both, thanks!

> I checked (manually) for any other logic change in hslToRgb.  The only
> difference I found was the near-noop change of which expression is used for the
> common light==0.5 case.  I see only minor arguments each way:

The change was unintentional.  I've changed to <=.

~TJ

Received on Tuesday, 28 January 2014 15:39:38 UTC