W3C home > Mailing lists > Public > www-style@w3.org > October 2013

Re: [css-flexbox] Fixing a mistake with flex-grow betwen 0 and 1

From: Daniel Holbert <dholbert@mozilla.com>
Date: Wed, 09 Oct 2013 08:03:04 -0700
Message-ID: <52557028.9050206@mozilla.com>
To: "Tab Atkins Jr." <jackalmage@gmail.com>, www-style list <www-style@w3.org>
Questions on the spec-tweak for this:

On 10/07/2013 04:10 PM, Tab Atkins Jr. wrote:
> In specific edits, this would just be a change in the
> <http://dev.w3.org/csswg/css-flexbox/#resolve-flexible-lengths>
> section - insert a step 2.5 that checks if the free space is positive
> and the sum of the flex-grows are <1, and if so, sets all the flex
> items to their hypothetical main size + the corresponding fraction of
> the free space, then exits the algorithm.

QUESTION 1:
Why do this as "step 2.5"?  I'd think that Step 5 ("Distribute free
space proportional to the flex factors") would be the obvious place to
make this tweak. (just changing the ratio that we use, if the sum of the
flex-grow factors is < 1, but otherwise doing everything normally)

QUESTION 2:
Why exit the algorithm? I'd expect that we'd need to proceed with the
"Fix min/max violations" and continue cycling as appropriate.
Otherwise, we'd never discover min/max violations, and we'd end up with
elements sized too small or too large for those constraints.
(If instead we moved this logic to be in Step 5, as suggested above, and
dropped the "exit", then I think we'd honor the constraints correctly...)

~Daniel
Received on Wednesday, 9 October 2013 15:03:36 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 22:51:03 UTC