Possible bug in ForwardFrame...

I found an instance when a forward frame is being told to unload but the manager (HttpManager) is null.  This causes the ForwardFrame to throw a null pointer exception and not shutdown the server properly.  From what I can tell during debugging, the forward frame never gets initialized, but it is some how added to list of resources to be unloaded.  My suggested code fix is listed below as well my setup.  

Let me know if you have any questions or the more appropriate place to fix this.
Brian


My setup:

The root of the server is pointing to the following virtual host directory, and the followup property in the virtualhost frame attached to the VirtualHostDirectory points to the root node of the server.

VirtualHostDirectory
	|- FramedResource (server1.company.com:8001)
		|- MirrorFrame
	|- FramedResource (server2.company.com:8001)
		|- MirrorFrame 
	|- FramedResource (server3.company.com:8001)
		|- MirrorFrame 



Current Code in ForwardFrame:
    public synchronized void notifyUnload()  {
        manager.sync();
        super.notifyUnload();
    }



Suggested fix:
    public synchronized void notifyUnload() 
    {
        if (manager != null)
            manager.sync();
            
        super.notifyUnload();
    }

Received on Wednesday, 9 April 2003 18:08:43 UTC