Re: Debian patches review

On Monday 20 August 2007 14:22, Regis Boudin wrote:
> Hi,
>
> So you know what's going on with the Debian packages, here is a quick
> review of the patches I currently apply to the Amaya source code, which
> are attached.
>
> * cflags_cleanup.diff : removes the forcing of CFLAGS, so they can be set
> when calling configure.
> * rdf_conf_in_conf.diff : moves the call to redland configure from
> Makefile.in to configure.in.
> * raptor.diff : only use libraptor instead of librdf, as no symbol from
> the redland library is actually used.
> * enable_system_libwww.diff : add a "--enable-system-libww" flag, and
> moves the call to the libwww configure to configure.in.
>
> I know you don't plan to merge the first one, it is only here for
> reference. As you reverted the second one, I guess you had issues with it.
> I would appreciate any feedback so I can modify it to be in a good enough
> shape to be included. Could you please try to build (like you would do for
> a release) for MacOSX/Fedora, so we can try to have it merged cleanly ?

I reverted the second and the third one because I was not able to generate a 
rpm with these patches (raptor is not found).
Unfortunately I'm not able to explain more.

> When rdf_conf_in_conf is successfully applied, adding raptor.diff should be
> fairly trivial. The result is quite interesting, as, since the removal of
> the bookmarks feature, redland is not used at all anymore.

> the libwww patch is quite intrusive, so I won't try to push it. Still, if
> anyone wants to try it, any feedback will be welcome.
>
> As usual, any question is welcome, I will be more than happy to help.
>
> Thanks,
> Regis

-- 
     Irène.
-----
Irène Vatton                     INRIA Rhône-Alpes
INRIA                               ZIRST
e-mail: Irene.Vatton@inria.fr       655 avenue de l'Europe
Tel.: +33 4 76 61 53 61             Montbonnot
Fax:  +33 4 76 61 52 07             38334 Saint Ismier Cedex - France

Received on Friday, 24 August 2007 11:08:53 UTC