W3C home > Mailing lists > Public > whatwg@whatwg.org > July 2013

Re: [whatwg] Proposal: createImageBitmap should return a "Promise" instead of using a callback

From: Silvia Pfeiffer <silviapfeiffer1@gmail.com>
Date: Thu, 18 Jul 2013 10:22:41 +1000
Message-ID: <CAHp8n2kjHjLbFqixTDC8VGOhf-kO9vduC4aS-bz+uu_dwQDKKA@mail.gmail.com>
To: Ian Hickson <ian@hixie.ch>
Cc: Justin Novosad <junov@google.com>, WHAT Working Group <whatwg@whatwg.org>
On Thu, Jul 18, 2013 at 10:00 AM, Ian Hickson <ian@hixie.ch> wrote:
> On Wed, 17 Jul 2013, Justin Novosad wrote:
>> On Wed, Jul 17, 2013 at 6:54 PM, Ian Hickson <ian@hixie.ch> wrote:
>> > On Thu, 18 Jul 2013, Silvia Pfeiffer wrote:
>> > > At the same time, I think we should follow a clear pattern for
>> > > introducing a Promise based API, which the .create() approach would
>> > > provide.
>> >
>> > I don't understand what that means.
>>
>> I think the concern is about the case where we end up with legacy
>> callback Factory methods that co-exist new with Promise-based flavors of
>> the factory methods. There's no technical obstacle to having the two
>> co-exist with the same name, it's just an overload.

Yes, that's my concern.


> I guess I don't understand what methods we're talking about here. Can we
> be more concrete? I am very much in favour of not having redundant APIs,
> not having lots of different kinds of APIs. But I'm not aware of this
> problem existing here. We have constructors and synchronous factory
> methods, have had for over a decade, and we're slowly adding constructors
> where it makes sense and not adding new synchronous factory methods. But
> in the case of ImageData, we need an asynchronous factory. This is unusual
> in the Web; mostly we have instead returned incomplete objects. In this
> case, the whole point of the API is to avoid this. This means we need a
> callback mechanism; Promises are a good, non-invasive way to do this.

We have the same issues with WebRTC, which already has a callback
based API, but there is a suggestion to replace/augment with a Promise
based API, so I just wanted to understand the motivation, potential
complications and implications.

One issue is the change in API paradigm that we use. People have got
used to wrapping the callback API with a Promise style API when they
need it. Now they have to do both: wrap the browser API for a Promise
style API and wrap it for a callback style API.

It may well be that Promises are the right way to go for
createImageBitmap(), but we are blazing a new trail here and need to
be careful about the implications. For example, here is an interesting
discussion thread with a statement that node.js originally used
Promises, but moved away from them for several reasons, not least
because they created a 20% performance degradation with v8:
https://github.com/gladiusjs/gladius-core/issues/127#issuecomment-5212272
.

I just want us to be clear about the situations in which we should
take this step and where we should avoid it.

Silvia.
Received on Thursday, 18 July 2013 00:23:26 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 17:00:03 UTC