Re: [whatwg] 2D canvas feature proposal: text decoration

On Thu, Apr 18, 2013 at 2:00 PM, Justin Novosad <junov@google.com> wrote:

> On Thu, Apr 18, 2013 at 4:44 PM, Rik Cabanier <cabanier@gmail.com> wrote:
>
>>
>> This seems very reasonable.
>> I wonder if we should use a DOMString or go to something more
>> JavaScript-y like a JSON object or an interface with enums.
>>
>>
> I agree that strings are not the best type for this, but you're talking
> about a rather fundamental break in consistency with respect to the rest of
> the spec.
> Other similar existing CanvasDrawingStyles properties (e.g. textAlign)
> use strings, and the text-decoration CSS property is also a string.
>

I think that all enumerated DOMStrings in CanvasDrawingStyles should move
to enums. This seems cleaner and have no compatibility issues.
However, if we keep them as DOMStrings, I agree that textDecoration should
be one too.

Received on Thursday, 18 April 2013 23:04:46 UTC