W3C home > Mailing lists > Public > whatwg@whatwg.org > August 2010

[whatwg] base64 entities

From: Kornel Lesiński <kornel@geekhood.net>
Date: Wed, 25 Aug 2010 22:52:42 +0100
Message-ID: <D00641E8-F7B3-4B91-9A58-58FF1970BFF7@geekhood.net>
> == Workarounds ==
> Currently, authors must carefully escape all untrusted content to
> prevent an attacker from injecting HTML.  Unfortunately, authors often
> apply the incorrect escaping or forget to escape entirely, resulting
> in security vulnerabilities.  Escaping content in HTML is tricky
> because authors need to use different escaping rules for different
> contexts.  For example, PHP's htmlspecialchars isn't sufficient in the
> following contexts:
> <img alt=<?php echo htmlspecialchars($name) ?> src="...">
> <script>
> elmt.innerHTML = 'Hi there <?php echo htmlspecialchars($name) ?>.';
> </script>

These cases can be secured without any new features in browsers (by escaping whitespace using numeric entities):

function htmlescape($str) {
	return preg_replace('/[\s<>"\'&]/e','"&".ord("$0").";"',$str);

I don't think that another escaping method would substantially improve PHP's situation. In my experience there are much more common problems that this won't solve:

? authors don't realize that echoed data may be dangerous, e.g. they expect to get a number, and it never occurs to them that field intended for numbers isn't guaranteed to contain only numbers. Some mistakenly believe that XSS is harmless (that it affects only attacker's own browser). They wouldn't use the new escaping method.

? PHP uses fundamentally flawed approach that requires authors to remember to escape all values all the time, and inevitably authors forget to do it sometimes. A better method, when forgotten, won't help at all.

? Novice authors don't understand escaping and end up using wrong approach (e.g. strip_tags() and filtering of input rather than output). Escaping method that makes escaped text opaque is going to be very confusing to authors who don't understand concept of escaping.

regards, Kornel
Received on Wednesday, 25 August 2010 14:52:42 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 16:59:26 UTC