[webrtc-pc] RTCStats::timestamp discrepancy between webrtc-stats and webrtc-pc (#3004)

henbos has just created a new issue for https://github.com/w3c/webrtc-pc:

== RTCStats::timestamp discrepancy between webrtc-stats and webrtc-pc ==
In webrtc-stats it [says](https://w3c.github.io/webrtc-stats/#dom-rtcstats-timestamp):

> Timestamps are expressed with [DOMHighResTimeStamp](https://www.w3.org/TR/hr-time-3/#dom-domhighrestimestamp) [[HIGHRES-TIME](https://w3c.github.io/webrtc-stats/#bib-highres-time)], and are defined as [Performance](https://www.w3.org/TR/hr-time-3/#dom-performance).[timeOrigin](https://www.w3.org/TR/hr-time-3/#dom-performance-timeorigin) + [Performance](https://www.w3.org/TR/hr-time-3/#dom-performance).[now](https://www.w3.org/TR/hr-time-3/#dom-performance-now)() at the time the information is collected.

Which is consistent with most timestamps that we've defined for the last several years and ensures monotonically incrementing etc, so it's always possible to do "delta fooStat / delta timestamp".

But the timestamp definition in webrtc-pc is really old and it [says](https://w3c.github.io/webrtc-pc/#dom-rtcstats-timestamp):

> The [timestamp](https://github.com/w3c/webrtc-pc/issues/new#dom-rtcstats-timestamp), of type [DOMHighResTimeStamp](https://www.w3.org/TR/hr-time-3/#dom-domhighrestimestamp), associated with this object. The time is relative to the UNIX epoch (Jan 1, 1970, UTC).

It doesn't really say but this sounds like a wall clock that is not necessarily always monotonically incrementing. I think this is a mistake and it should say Performance here as well to align with all other timestamps, otherwise there will be edge cases where things break.

We noticed a bug relating to wall clock vs performance where it would diverge if the laptop went to sleep and then the page resumed...

Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/3004 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 19 September 2024 13:58:29 UTC