W3C home > Mailing lists > Public > public-webrtc@w3.org > August 2017

[webrtc-pc] Pull Request: Formalize how createOffer interacts with identity providers.

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Wed, 09 Aug 2017 01:24:42 +0000
To: public-webrtc@w3.org
Message-ID: <pull_request.opened-134792042-1502241880-sysbot+gh@w3.org>
taylor-b has just submitted a new pull request for https://github.com/w3c/webrtc-pc:

== Formalize how createOffer interacts with identity providers. ==
Fixes #1184.

This cleans things up slightly, and fixes a corner case race condition,
where in the following sequence:

```
pc.setIdentityProvider(a);
pc.createOffer().then(...);
pc.setIdentityProvider(b);
pc.createOffer().then(...);
```

It wasn't completely clear if the first `createOffer` would use the
assertion from `a` or `b`. The answer now is "it will use `a`".

See https://github.com/w3c/webrtc-pc/pull/1522
Received on Wednesday, 9 August 2017 01:24:43 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:18:36 UTC