W3C home > Mailing lists > Public > public-webrtc@w3.org > August 2017

[webrtc-pc] setParameters does input validation in parallel, and doesn't actually apply parameters?

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Wed, 09 Aug 2017 01:00:54 +0000
To: public-webrtc@w3.org
Message-ID: <issues.opened-248888238-1502240452-sysbot+gh@w3.org>
taylor-b has just created a new issue for https://github.com/w3c/webrtc-pc:

== setParameters does input validation in parallel, and doesn't actually apply parameters? ==
The only steps listed in the `setParameters` algorithm do input validation. It's not clear why these steps are done in parallel, especially where they interact with `getParameters` (which is synchronous), which introduces race conditions.

If the reason we made `setParameters` promise-based was because it may involve I/O operations that can fail, then a more sensible algorithm to me would be:

1. Do input validation synchronously.
2. In parallel, attempt to start using parameters, resolving or rejecting promise appropriately.

Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1520 using your GitHub account
Received on Wednesday, 9 August 2017 01:00:56 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:51 UTC