Re: Proposal for removing createDTMFSender and canInsertDTMF

That will break some existing code but I think it is a good change and we should do it. 

On Nov 4, 2014, at 11:18 AM, Harald Alvestrand <harald@alvestrand.no> wrote:

> This makes sense to me.
> 
> https://www.w3.org/Bugs/Public/show_bug.cgi?id=27213 is the bug I filed
> during the meeting for it; I've added the description below to the bug's
> description - it's already assigned to Peter.
> 
> 
> On 11/03/2014 01:37 PM, Peter Thatcher wrote:
>> At TPAC 2014, we realized that now that we have RtpSender, we don't
>> need a DTMFSender to be tied to a track.  We can tie it to an
>> RtpSender instead, and that would clean things up a fair bit.
>> 
>> Based on that, I propose we: 
>> 
>> 1. Remove RTCPeerConnection.createDTMFSender
>> 2. Add RTCRtpSender.dtmf, of type "RTCDTMFSender?".
>> 3. Remove RTCDTMFSender.canInsertDTMF and RTCDTMFSender.track.
>> 
>> The rule is: If RtpSender.dtmf is non-null, you can send DTMF.  Here
>> is an example:
>> 
>> var pc = ...;
>> var track = ...;
>> var rtpSender = pc.addTrack(track);
>> if (rtpSender.dtmf) {
>>  rtpSender.dtmf.insertDTMF(...);
>> }
>> 
>> And here is the WebIDL:
>> 
>> interface RTCDTMFSender {
>>    void insertDTMF(DOMString tones, 
>>                    optional long duration = 100, 
>>                    optional long interToneGap = 70);
>>                attribute EventHandler ontonechange;
>>    readonly    attribute DOMString    toneBuffer;
>>    readonly    attribute long         duration;
>>    readonly    attribute long         interToneGap;
>> };
>> 
>> partial interface RtpSender {
>>    readonly attribute RTCDTMFSender? dtmf;
>> }
>> 
>> 
> 
> 
> -- 
> Surveillance is pervasive. Go Dark.
> 
> 

Received on Wednesday, 5 November 2014 05:08:37 UTC