W3C home > Mailing lists > Public > public-webrtc@w3.org > June 2014

Re: [Bug 25976] DTMFSender.insertDTMF steps should validate the values of duration and interToneGap.

From: Adam Bergkvist <adam.bergkvist@ericsson.com>
Date: Wed, 11 Jun 2014 08:28:02 +0200
Message-ID: <5397F6F2.3030000@ericsson.com>
To: Harald Alvestrand <harald@alvestrand.no>, <public-webrtc@w3.org>
On 2014-06-09 13:32, Harald Alvestrand wrote:
> On 06/09/2014 10:35 AM, bugzilla@jessica.w3.org wrote:
>> https://www.w3.org/Bugs/Public/show_bug.cgi?id=25976
>>
>> Adam Bergkvist <adam.bergkvist@ericsson.com> changed:
>>
>>             What    |Removed                     |Added
>> ----------------------------------------------------------------------------
>>
>>               Status|NEW                         |RESOLVED
>>           Resolution|---                         |FIXED
>>
>> --- Comment #2 from Adam Bergkvist <adam.bergkvist@ericsson.com> ---
>> Added default values to the idl and updated the algorithm.
>>
>> Proposed fix:
>> https://github.com/fluffy/webrtc-w3c/commit/02f5a3ac13c9c343747be75b8d8a2a874d5b8d8c
>>
>>
>> Closing bug.
>>
> Looks mainly good to me.
>
> Nittish comment:
>
> I think
>
> <dt>void insertDTMF(in DOMString tones, optional long duration = 100,
>   +        long interToneGap = 70)</dt>
>
> should be
>
> <dt>void insertDTMF(in DOMString tones, optional long duration = 100,
>   +        optional long interToneGap = 70)</dt>
>
> As far as I read section 3.2.3 of http://www.w3.org/TR/WebIDL/ you have
> to have the keyword "optional" in front of anything that's declared with
> a default value (grammar rule [44]).

That's right. I'm pretty sure that Respec.js used to automatically add 
optional to the subsequent arguments if one was optional (at one point 
we ended up with double optional when we added them manually).

It's fixed now an I've gone through both docs to check for similar cases.

/Adam
Received on Wednesday, 11 June 2014 06:28:32 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:41 UTC