W3C home > Mailing lists > Public > public-webrtc@w3.org > June 2014

Re: [Bug 25976] DTMFSender.insertDTMF steps should validate the values of duration and interToneGap.

From: Harald Alvestrand <harald@alvestrand.no>
Date: Mon, 09 Jun 2014 13:32:33 +0200
Message-ID: <53959B51.7070801@alvestrand.no>
To: public-webrtc@w3.org
On 06/09/2014 10:35 AM, bugzilla@jessica.w3.org wrote:
> https://www.w3.org/Bugs/Public/show_bug.cgi?id=25976
>
> Adam Bergkvist <adam.bergkvist@ericsson.com> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>               Status|NEW                         |RESOLVED
>           Resolution|---                         |FIXED
>
> --- Comment #2 from Adam Bergkvist <adam.bergkvist@ericsson.com> ---
> Added default values to the idl and updated the algorithm.
>
> Proposed fix:
> https://github.com/fluffy/webrtc-w3c/commit/02f5a3ac13c9c343747be75b8d8a2a874d5b8d8c
>
> Closing bug.
>
Looks mainly good to me.

Nittish comment:

I think

<dt>void insertDTMF(in DOMString tones, optional long duration = 100,
  +        long interToneGap = 70)</dt>

should be

<dt>void insertDTMF(in DOMString tones, optional long duration = 100,
  +        optional long interToneGap = 70)</dt>

As far as I read section 3.2.3 of http://www.w3.org/TR/WebIDL/ you have 
to have the keyword "optional" in front of anything that's declared with 
a default value (grammar rule [44]).
Received on Monday, 9 June 2014 11:33:05 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:41 UTC