- From: henbos via GitHub <sysbot+gh@w3.org>
- Date: Fri, 22 Nov 2024 11:00:27 +0000
- To: public-webrtc-logs@w3.org
Btw I had said during the meeting that I thought all instances of "codec matching" could ignore level, but upon a second look I realized that we don't need to be that "loose" in most cases. For example if you addTransceiver, the only valid input is from getCapabilities since there is no chance that anything else has been negotiated for that transceiver yet. Ultimately we only need to "ignoreLevels=true" at a couple of places: - When negotiation completes, the check to see if the codec was negotiated away and for maybe clearing setParameters's codec value, this should not remove the codec because of a level mismatch. - When setParameters is called, this should not throw due to level mismatch (= "Proposal A"). - In addition I clarified that the "RTCRtpEncodingParameters.codec" picks codec based on "ignoreLevels=true" for the same reason that setParameters is supposed to work here, but this was never called out before. In all other cases we can "ignoreLevels=false", which the PR reflects now. -- GitHub Notification of comment by henbos Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/3023#issuecomment-2493485027 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 22 November 2024 11:00:28 UTC