W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2022

Re: [webrtc-pc] insertDTMF is synchronous, but relies on asynchronous state-checking logic (#2738)

From: Harald Alvestrand via GitHub <sysbot+gh@w3.org>
Date: Tue, 31 May 2022 15:16:15 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1142270728-1654010173-sysbot+gh@w3.org> 
On reading through the validation steps, I don't see anything that would require them to be async, and it's referenced from 2 places - once from a sync method, and one from reading an attribute.

I suggest removing the "queue a task" part from "determine if DTMF can be sent".


-- 
GitHub Notification of comment by alvestrand
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2738#issuecomment-1142270728 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 31 May 2022 15:16:16 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:57 UTC