Re: [webrtc-pc] Inconsistent initialization of scaleResolutionDownBy (#2730)

> It would be tempting to default scaleResolutionDownBy to 1 in the IDL, but that can't be done because the sendEncodings field is defined for both audio and video (although I'm unaware of anyone using it for audio).
> 
> The initialization rule given in https://w3c.github.io/webrtc-pc/#dom-rtcrtpencodingparameters-scaleresolutiondownby is consistent with always initializing it to 1 when there is a single layer.

On the subject of audio; what should we be doing when JS passes scaleResolutionDownBy to addTransceiver('audio')? TypeError? The spec clearly says that it is invalid to use scaleResolutionDownBy in the audio case.

Also, the steps in addTransceiver require auto-filling scaleResolutionDownBy regardless of the media kind (either the "fill with 1" case, or the "powers of 2" case). This is almost certainly not what we want. That might also be a TypeError?

-- 
GitHub Notification of comment by docfaraday
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2730#issuecomment-1122960622 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 10 May 2022 22:27:50 UTC