W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2022

Re: [mediacapture-region] Refer to getBoundingClientRect as a defintion of the actual crop area (#32)

From: youennf via GitHub <sysbot+gh@w3.org>
Date: Mon, 28 Mar 2022 13:49:38 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1080677140-1648475376-sysbot+gh@w3.org>
I did not follow the discussion so I'm a bit lost where you all are.
In any case, the following approach seems the most promising to me and this PR is based doing that.
- Introduce a slot storing a weak reference to the element.
- When serializing, store the weak reference.
- When deserialising, set the weak reference. 
- Drop the CropTarget. <-> HTMLElement relationship.

I think I kept the HTMLElement requirement (no API change).
I can further tweak the bits that might be ambiguous or that do not have yet consensus.

GitHub Notification of comment by youennf
Please view or discuss this issue at https://github.com/w3c/mediacapture-region/pull/32#issuecomment-1080677140 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 28 March 2022 13:49:43 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:56 UTC