W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2022

Re: [mediacapture-region] Definition of valid CropTarget might be too loose (#29)

From: Elad Alon via GitHub <sysbot+gh@w3.org>
Date: Mon, 21 Mar 2022 16:33:38 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1074130777-1647880416-sysbot+gh@w3.org>
> > So I prefer `cropTo` spell out its input validation steps explicitly and synchronously
> 
> Note though that validating that a CropTarget is still referencing an existing element cannot be guaranteed synchronously. Validating that it is part of the right top level document seems ok to do synchronously.

It's not immediately obvious that we would even want to expose that it's referring to an existing, non-garbaged collected Element, as that exposes information about garbage-collection. I think it's best to check (asynchronously) that the CropTarget was minted for an Element that was part of the same "tab". (That is, in a browsing context that is a descendant of the top-level document's browsing context yada yada...)

-- 
GitHub Notification of comment by eladalon1983
Please view or discuss this issue at https://github.com/w3c/mediacapture-region/issues/29#issuecomment-1074130777 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 21 March 2022 16:33:39 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:56 UTC