W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2022

Re: [mediacapture-region] Definition of valid CropTarget might be too loose (#29)

From: Elad Alon via GitHub <sysbot+gh@w3.org>
Date: Mon, 21 Mar 2022 15:21:05 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1074033153-1647876063-sysbot+gh@w3.org>
> A CropTarget is defined in terms of browsing context which can potentially outlive navigations.

Sure, if we have a way of defining things in a better way, let's do so. But note that allowing a CropTarget to outlive navigation would effectively mean cropping the track mutes it, as no additional frames would be produced that have >0 pixels. So not a security concern, whether we reject `cropTo()` or make it "mute" the track.

> 1. If the target's element is no longer around, bail

That seems fine.

> 2. If that element is no longer in a document, bail

Can you explain the distinction between this and the previous?

> If that document is not this (track)'s captured [top-level browsing context](https://html.spec.whatwg.org/multipage/browsers.html#top-level-browsing-context)'s [active document](https://html.spec.whatwg.org/multipage/browsers.html#active-document), or not an [active document](https://html.spec.whatwg.org/multipage/browsers.html#active-document) in one of this (track)'s captured [top-level browsing context](https://html.spec.whatwg.org/multipage/browsers.html#top-level-browsing-context)'s [nested browsing context](https://html.spec.whatwg.org/multipage/browsers.html#nested-browsing-context)s, bail.

Seems reasonable on first glance.

GitHub Notification of comment by eladalon1983
Please view or discuss this issue at https://github.com/w3c/mediacapture-region/issues/29#issuecomment-1074033153 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 21 March 2022 15:21:06 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:56 UTC