W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > December 2022

Re: [webrtc-extensions] Potential web compat issue with setOfferedRtpHeaderExtensions (#130)

From: Philipp Hancke via GitHub <sysbot+gh@w3.org>
Date: Wed, 07 Dec 2022 07:47:36 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1340532363-1670399254-sysbot+gh@w3.org>
> Compare to [setOfferedRtpHeaderExtensions](https://w3c.github.io/webrtc-extensions/#dom-rtcrtptransceiver-setofferedrtpheaderextensions), where leaving out a header extension means: don't modify it and leave it as-is
Right, so
const pc = new RTCPeerConnection();
const t = pc.addTransceiver('audio');
t.setOfferedRtpHeaderExtensions([{uri: "urn:ietf:params:rtp-hdrext:ssrc-audio-level", direction: "stopped"}]);
const offer = await pc.createOffer();
console.log(offer.sdp.split('\r\n').filter(l => l.startsWith('a=extmap:')))
will, in Chrome, remove ssrc-audio-level but leave the other three extensions untouched.

That should be easy to fix by changing https://w3c.github.io/webrtc-extensions/#methods to look at (a copy of) the offered header extensions with everything set to stopped, then enabling based on the input.

GitHub Notification of comment by fippo
Please view or discuss this issue at https://github.com/w3c/webrtc-extensions/issues/130#issuecomment-1340532363 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 7 December 2022 07:47:37 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:59 UTC