- From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
- Date: Thu, 24 Sep 2020 18:31:39 +0000
- To: public-webrtc-logs@w3.org
I also recommend we switching to patching algorithms¹ for greater specificity, since constraints are used in both `getUserMedia` and `applyConstraints`, and the current prose makes it hard to tell where it applies (`getUserMedia` only right?) As to how to write input validation steps to throw on `exact` ptz constraints, there's precedent in [getDisplayMedia](https://w3c.github.io/mediacapture-screen-share/#dom-mediadevices-getdisplaymedia), so I would look at that: _"4. For each existing member in constraints whose value, CS, is a dictionary, run the following steps: ... If CS contains a member whose name specifies a constrainable property ..., and whose value in turn is a dictionary containing a member named either min or exact, return a promise rejected with a newly created TypeError."_ We should probably also throw `TypeError`, not `OverconstrainedError`, to be consistent with that precedent. --- <sub>1. I did some algorithm patching a while ago [here](https://w3c.github.io/webrtc-identity/identity.html#creating-an-offer), if you need an example.</sub> -- GitHub Notification of comment by jan-ivar Please view or discuss this issue at https://github.com/w3c/mediacapture-image/pull/261#issuecomment-698514049 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 24 September 2020 18:31:41 UTC