- From: youennf via GitHub <sysbot+gh@w3.org>
- Date: Fri, 04 Sep 2020 10:37:42 +0000
- To: public-webrtc-logs@w3.org
> The upsides of the change: Which change are you referring to? As of capture indicator benefit, I am specifically talking of https://github.com/w3c/mediacapture-main/pull/717. If you are referring to enumerateDevices sanitisation (the fact that enumerateDevices should not leak until the page starts capturing), the benefits have been described in https://github.com/w3c/mediacapture-main/issues/709#issuecomment-686409911. > Therefore there can be no correlation between capture indicators and enumerateDevices(). There is a strong correlation: a page will get full enumerateDevices access at a time where capture indicators will be visible. Past that point, the page will most likely continue getting full enumerateDevices access for its whole lifetime. > * change in API behaviour affects existing code in the wild Are you specifically referring to https://github.com/w3c/mediacapture-main/pull/717 or to enumerateDevices sanitization? If the former, this should really be an edge case (a device that fails to open should be an edge case). Or am I missing something? If it is the latter, I agree this is an important change and I am more than happy to discuss how to best migrate. Please provide links to specific code bases or web sites. Note also that if this behavior breaks an application, it means it is broken in Safari for a few years now. > * the new behaviour is not efficient (examples given require multiple device opens to workaround new behaviour) Are you specifically referring to https://github.com/w3c/mediacapture-main/pull/717 or to enumerateDevices sanitization? Would you be able to file an issue specifically for that? Based on that, we might want to tighten the rules of device selection, how to go from finalSet to the actual selected track. Guessing it is about enumerateDevices sanitization, the example should have the following requirements: 1. Before sanitization change, the page should do one successful getUserMedia call and get the expected device. 2. After sanitization change, there is no way for the page to get the expected device with just one successful getUserMedia call. -- GitHub Notification of comment by youennf Please view or discuss this issue at https://github.com/w3c/mediacapture-main/issues/709#issuecomment-687067564 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 4 September 2020 10:37:44 UTC