W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > September 2019

Re: [mediacapture-record] Defer deciding codec until data is available and onstart fires (#190)

From: henbos via GitHub <sysbot+gh@w3.org>
Date: Fri, 27 Sep 2019 11:07:53 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-535895715-1569582471-sysbot+gh@w3.org>
> I'm thinking it'd be simpler and clearer to just move the step of Modify |extendedMimeType| by adding media type, subtype and codecs parameter... to when firing "start". I.e., to not even set the mimeType attribute synchronously in start().
> 
> The spec change for setting it synchronously in start() was recent enough that no-one is implementing it yet. I have implemented it in Firefox but those patches are still under review.
> 
> It would allow you to avoid duplicating language about extending and setting the mime type according to the configuration of the recorder.
> And most of all it avoids forcing applications to handle two paths (mimetype present vs not present) where one is so rare (mimetype not preset) it's going to be easily missed.

Oh that's great, it's what I would have preferred so that mimeType is always only updated in one place, that's less surprises for developers. I'll update the PR again.

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/mediacapture-record/pull/190#issuecomment-535895715 using your GitHub account
Received on Friday, 27 September 2019 11:07:54 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:29 UTC