Re: [webrtc-stats] Clarify concealedSamples (#406)

I think "does not represent incoming data" means that the concealment audio
does not come from incoming audio packets, but is made up by the jitter
buffer to conceal the fact that a packet was missing (either lost or
delayed).

If we are playing out at timestamp t and don't have the necessary packet
available, but we do have a packet at t+200ms available the jitter buffer
should indeed play out concealment samples. I don't think that is
contradictory with the text though.

On Mon, Mar 18, 2019 at 3:01 PM Varun Singh <notifications@github.com>
wrote:

> *@vr000m* commented on this pull request.
> ------------------------------
>
> In webrtc-stats.html
> <https://github.com/w3c/webrtc-stats/pull/406#discussion_r266452666>:
>
> > @@ -2695,8 +2695,9 @@ <h2>
>                <dd>
>                  <p>
>                    The total number of samples that are concealed samples. A concealed sample is a
> -                  sample that is based on data that was synthesized to conceal packet loss and does
> -                  not represent incoming data.
> +                  sample that is based on data that was synthesized to conceal packet loss or
> +                  packets arriving late and does not represent incoming data. These samples are
> +                  generated when we don't have the necessary non-concealed samples in the buffer.
>
> These samples are generated when we don't have the necessary non-concealed
> samples in the buffer.
>
> I dont think this is accurate, if playing out timestamp t and is missing
> packets, and the packets in the Jitter Buffer are already present at
> (t+200ms), would the application not add concealment samples??
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/w3c/webrtc-stats/pull/406#discussion_r266452666>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ARGCopZtOBm9T_c1Uu2LLlpZQ4mYCCAFks5vX5xLgaJpZM4b5Ulk>
> .
>


-- 
GitHub Notification of comment by ivocreusen
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/pull/406#issuecomment-473960435 using your GitHub account

Received on Monday, 18 March 2019 15:29:17 UTC