Re: [webrtc-pc] RTCIceCandidateInit has no required fields, so should probably be optional in addIceCandidate (#2125)

Depends. To discourage anything but `addIceCandidate({candidate: signaledCandidate})`, then yeah we could *require* `addIceCandidate({candidate: ""})` and remove the `""` default. This would make it harder to end candidates "manually" or accidentally.

This is the opposite of WebIDL advice which aims to make calling APIs simpler, but we have a reason. I don't have a strong opinion however.

The legacy API is OK: the dictionary is not in trailing position there and doesn't [need to be optional](

GitHub Notification of comment by jan-ivar
Please view or discuss this issue at using your GitHub account

Received on Tuesday, 12 March 2019 22:12:31 UTC