W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2019

Re: [webrtc-pc] Add pc.restartIce() method. (#2169)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Tue, 09 Jul 2019 15:07:25 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-509681629-1562684837-sysbot+gh@w3.org>
@henbos Great! At this rate you might beat me to it (I held off since Firefox merge day was yesterday)!

> In both SLD(answer) and SRD(answer) I am comparing the set description with the current ICE credentials, based on looking at [[CurrentLocalDescription]].

That sounds right. Note though that in [our implementation](https://phabricator.services.mozilla.com/D30976#C975916NL1170) we compare against currentLocalDescription from when `pc.restartIce()` was called. I think I was concerned about partial restarts from the other side moving the goalpost (but note bug I found from thinking about this again, thanks!)

> I am wondering [if sometimes we need to restart ICE twice?](https://webrtc-review.googlesource.com/c/src/+/144941/1/pc/peer_connection_ice_unittest.cc#887)

I answered [here](https://webrtc-review.googlesource.com/c/src/+/144941/1#message-a5cb61ee5f4a02097f00edea898e40824449c9e6). To me, this mirrors how e.g. `direction` works: we don't trigger on every set, only on value change. That seems most conservative to me. The alternative would be to have calling `pc.restartIce()` 10 times in a row trigger 10 renegotiations restarting ICE 10 times, which seems undesirable.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2169#issuecomment-509681629 using your GitHub account
Received on Tuesday, 9 July 2019 15:07:27 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:25 UTC