W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2019

Re: [webrtc-pc] Add pc.restartIce() method. (#2169)

From: henbos via GitHub <sysbot+gh@w3.org>
Date: Tue, 09 Jul 2019 13:18:08 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-509638183-1562678287-sysbot+gh@w3.org>
I have a working webrtc.org implementation of what I think this PR intends to do, [code here](https://webrtc-review.googlesource.com/c/src/+/144941). @jan-ivar is this correct?
1. In both SLD(answer) and SRD(answer) I am comparing the set description with the current ICE credentials, based on looking at [[CurrentLocalDescription]].
2. Because restartIce() does not take signalingState into account, this causes the [[RestartIce]] slot to reset when the O/A finishes, even if restartIce() was called after createOffer(). I am wondering [if sometimes we need to restart ICE twice](https://webrtc-review.googlesource.com/c/src/+/144941/1/pc/peer_connection_ice_unittest.cc#887)?

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2169#issuecomment-509638183 using your GitHub account
Received on Tuesday, 9 July 2019 13:18:10 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:25 UTC